You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/09/14 00:58:51 UTC
[jira] [Commented] (CB-4806) Update splashscreen image bounds for
iOS 7
[ https://issues.apache.org/jira/browse/CB-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767116#comment-13767116 ]
ASF subversion and git services commented on CB-4806:
-----------------------------------------------------
Commit 96d5875dc38515c75c969284d252ed1cfbb34310 in branch refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=96d5875 ]
[CB-4806] Update splashscreen image bounds for iOS 7
> Update splashscreen image bounds for iOS 7
> ------------------------------------------
>
> Key: CB-4806
> URL: https://issues.apache.org/jira/browse/CB-4806
> Project: Apache Cordova
> Issue Type: Task
> Components: iOS, Plugin SplashScreen
> Affects Versions: Master
> Reporter: Shazron Abdullah
> Assignee: Shazron Abdullah
> Labels: ios7
> Fix For: 3.1.0
>
>
> See code from this thread: http://markmail.org/message/khqi5vpubxp2qppk
> diff replicated below:
> {code}
> diff --git a/CordovaLib/Classes/CDVSplashScreen.m
> b/CordovaLib/Classes/CDVSplashScreen.m
> index fdb79fa..809ce35 100644
> --- a/CordovaLib/Classes/CDVSplashScreen.m
> +++ b/CordovaLib/Classes/CDVSplashScreen.m
> @@ -170,7 +170,9 @@
> // There's a special case when the image is the size of the screen.
> if (CGSizeEqualToSize(screenSize, imgBounds.size)) {
> CGRect statusFrame = [self.viewController.view
> convertRect:[UIApplication sharedApplication].statusBarFrame fromView:nil];
> - imgBounds.origin.y -= statusFrame.size.height;
> + if (floor(NSFoundationVersionNumber) <=
> NSFoundationVersionNumber_iOS_6_1) {
> + imgBounds.origin.y -= statusFrame.size.height;
> + }
> } else {
> CGRect viewBounds = self.viewController.view.bounds;
> CGFloat imgAspect = imgBounds.size.width / imgBounds.size.height;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira