[jira] [Commented] (CAMEL-9660) HTTP producers crash when Exchange.HTTP_URI header contains unencoded unsafe characters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175129#comment-15175129 ] 

ASF GitHub Bot commented on CAMEL-9660:
---------------------------------------

GitHub user tadayosi opened a pull request:

    https://github.com/apache/camel/pull/878

    CAMEL-9660 - HTTP producers crash when Exchange.HTTP_URI header contains unencoded unsafe characters

    Please review and merge it. Thanks!
    
    https://issues.jboss.org/browse/ENTESB-4737

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tadayosi/camel CAMEL-9660

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #878
    
----
commit 01c0cd4fa33eec1e64e19967c5f4a0a7fa7a8545
Author: Tadayoshi Sato <sa...@gmail.com>
Date:   2016-03-02T06:26:46Z

    CAMEL-9660 - HTTP producers crash when Exchange.HTTP_URI header contains unencoded unsafe characters

----


> HTTP producers crash when Exchange.HTTP_URI header contains unencoded unsafe characters
> ---------------------------------------------------------------------------------------
>
>                 Key: CAMEL-9660
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9660
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-http, camel-http-common, camel-http4, camel-jetty
>    Affects Versions: 2.16.2, 2.17.0
>            Reporter: Tadayoshi Sato
>
> For instance,
> {code:java}
> template.sendBodyAndHeader("jetty:http://localhost:9000/test?bridgeEndpoint=true", "Hello World", Exchange.HTTP_URI, "/<>{}");
> {code}
> this test code crashes with the following error:
> {code}
> java.net.URISyntaxException: Illegal character in path at index 1: /<>{}
> {code}
> It is because there are places in the HTTP producers code where they are trying to create a {{java.net.URI}} instance based on the unsafe string "/<>{}".
> This issue causes practical problems when bridging between Netty HTTP consumer endpoints and those HTTP producer endpoints, since Netty consumers route IN messages with {{Exchange.HTTP_URI}} header being unencoded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)