You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/12/07 11:15:53 UTC
[GitHub] [cordova-ios] dertieran opened a new pull request #1210: Support extending export options
dertieran opened a new pull request #1210:
URL: https://github.com/apache/cordova-ios/pull/1210
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Support extending the `exportOptions` through the `buildOpts`.
Resolves #1209
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dertieran commented on pull request #1210: feat: support extending export options
Posted by GitBox <gi...@apache.org>.
dertieran commented on pull request #1210:
URL: https://github.com/apache/cordova-ios/pull/1210#issuecomment-1067703573
Not quite sure if this is what you mean, but I'm not using cordova through the cli.
So I didn't provide a way to set the `exportOptions` through the cli, but I guess it could be added as an option to the `build.json`.
I tested it through my build script that looks something like this
```js
const build = async function ({ release, platforms }) {
const exportOptions = { uploadSymbols: !release };
const options = { release, device: release, exportOptions };
await cordova.build({ verbose: !release, platforms, options });
};
build({ release: true, platforms: ['ios'] });
```
This will then not include the `.symbols` in the produced `.ipa` file.
This command should not print anything in that case *(by default it does)*.
```sh
unzip -l platforms/ios/build/device/<app>.ipa | grep Symbols
```
Also as mentioned in the issue, right now the code does not allow to overwrite the defaults.
Not sure if that would be a good idea or if it would break the whole build. 😅
I hope this helps, let me know if I can help with anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu edited a comment on pull request #1210: feat: support extending export options
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1210:
URL: https://github.com/apache/cordova-ios/pull/1210#issuecomment-1067655438
Code wise everything looks good.
Can you provide me your example build command on how you tested it. How you set a single or multiple export options.
This information needs to be added later to the Cordova docs so others understand how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on pull request #1210: feat: support extending export options
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1210:
URL: https://github.com/apache/cordova-ios/pull/1210#issuecomment-1067655438
Code wise everything looks good.
Can you provide me your example build command on how you tested it. How you set a single or multiple export options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org