You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/04 08:44:37 UTC

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2056: [CALCITE-4106] Consider "listCoerced" when TypeCoercionImpl#inOperationCoercion returns

Aaaaaaron edited a comment on pull request #2056:
URL: https://github.com/apache/calcite/pull/2056#issuecomment-653739736


   Hard to add UT.
   "testInOperation/testNotInOperation" is end to end test. 
   
   When you debug, you can find `inOperationCoercion` return false, but the tests can still pass cuz `ComparableOperandTypeChecker#checkOperandTypes` passes, and the casted expr has been updated.
   
   ![image](https://user-images.githubusercontent.com/15643702/86508808-86993680-be15-11ea-8721-4fd8c43b0b9f.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org