[GitHub] [netbeans] tmysik commented on a change in pull request #2265: [NETBEANS-4443] PHP 8.0 Support: Non-capturing catches part

[GitBox <gi...@apache.org>]

tmysik commented on a change in pull request #2265:
URL: https://github.com/apache/netbeans/pull/2265#discussion_r458706797



##########
File path: php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java
##########
@@ -84,7 +85,12 @@
      * PHP 7.4.
      * @since 2.65
      */
-    PHP_74(Bundle.PhpVersion_PHP_74());
+    PHP_74(Bundle.PhpVersion_PHP_74()),
+    /**
+     * PHP 8.0.
+     * @since 2.74
+     */
+    PHP_80(Bundle.PhpVersion_PHP_80());

Review comment:
       I see. Maybe some TODO file could be added with remaining tasks before merging into `master` (like increasing spec versions). Up to you to decide, of course.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists