[jira] [Commented] (KAFKA-13122) resource leak due to not close KeyValueIterator implemented instances

["Matthias J. Sax (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386412#comment-17386412 ] 

Matthias J. Sax commented on KAFKA-13122:
-----------------------------------------

Great catch!

> resource leak due to not close KeyValueIterator implemented instances
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-13122
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13122
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Luke Chen
>            Assignee: Luke Chen
>            Priority: Major
>
> Found there are "many" KeyValueIterator implemented instances don't explicitly get closed, which will cause resource leak.
> From the java doc in KeyValueIterator:
> {color:#808080}* Users must call its {{color}{color:#808080}@code {color}{color:#808080}close} method explicitly upon completeness to release resources{color}
>  
> This issue mostly happen in tests because we usually query state store to get result iterator, and then do verification, but forgot close it. This issue also *appear in the example code in our developer guide docs*.
>  
> I'll use try-with-resource to fix them. To avoid huge PR created, I split this bug into 3 sub-tasks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)