You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/25 16:13:41 UTC

[GitHub] [spark] cloud-fan commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

cloud-fan commented on pull request #31245:
URL: https://github.com/apache/spark/pull/31245#issuecomment-766928084


   Can we be more specific about the benefits? If we only want to unify the schema, we can directly change `ShowTablesCommand.output`. Passing around the output attributes should have more benefits like keeping the expr ID unchanged and avoid bugs when we apply more operators above the command output dataframe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org