You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2013/08/05 20:10:32 UTC

svn commit: r1510632 - /commons/proper/email/trunk/src/main/java/org/apache/commons/mail/EmailUtils.java

Author: britter
Date: Mon Aug  5 18:10:31 2013
New Revision: 1510632

URL: http://svn.apache.org/r1510632
Log:
buffer really wants to be a builder

Modified:
    commons/proper/email/trunk/src/main/java/org/apache/commons/mail/EmailUtils.java

Modified: commons/proper/email/trunk/src/main/java/org/apache/commons/mail/EmailUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/EmailUtils.java?rev=1510632&r1=1510631&r2=1510632&view=diff
==============================================================================
--- commons/proper/email/trunk/src/main/java/org/apache/commons/mail/EmailUtils.java (original)
+++ commons/proper/email/trunk/src/main/java/org/apache/commons/mail/EmailUtils.java Mon Aug  5 18:10:31 2013
@@ -285,7 +285,7 @@ final class EmailUtils
             return null;
         }
 
-        final StringBuilder buffer = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         for (byte c : input.getBytes(US_ASCII))
         {
             int b = c;
@@ -295,18 +295,18 @@ final class EmailUtils
             }
             if (SAFE_URL.get(b))
             {
-                buffer.append((char) b);
+                builder.append((char) b);
             }
             else
             {
-                buffer.append(ESCAPE_CHAR);
+                builder.append(ESCAPE_CHAR);
                 char hex1 = Character.toUpperCase(Character.forDigit((b >> 4) & 0xF, RADIX));
                 char hex2 = Character.toUpperCase(Character.forDigit(b & 0xF, RADIX));
-                buffer.append(hex1);
-                buffer.append(hex2);
+                builder.append(hex1);
+                builder.append(hex2);
             }
         }
-        return buffer.toString();
+        return builder.toString();
     }
 
     /**