[GitHub] mike-tutkowski commented on a change in pull request #2512: Only use the host if its Resource State is Enabled.

[GitBox <gi...@apache.org>]

mike-tutkowski commented on a change in pull request #2512: Only use the host if its Resource State is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#discussion_r177508146
 
 

 ##########
 File path: engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 ##########
 @@ -484,7 +483,7 @@ else if (volumeInfo.getFormat() == ImageFormat.OVA || volumeInfo.getFormat() ==
         }
 
         SnapshotResult result = null;
-        SnapshotInfo snapshotOnPrimary = null;
+        SnapshotInfo snapshotOnPrimary;
 
 Review comment:
   This is an IntelliJ-recommended change. The IDE pointed out (correctly) that we did not need to assign null on this line because snapshotOnPrimary is later assigned a value regardless of the path the code takes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services