You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Masato Nagai (JIRA)" <ji...@apache.org> on 2007/05/05 16:14:15 UTC

[jira] Created: (FOR-998) I created patch to resolve empty cell.

I created patch to resolve empty cell.
--------------------------------------

                 Key: FOR-998
                 URL: https://issues.apache.org/jira/browse/FOR-998
             Project: Forrest
          Issue Type: Bug
          Components: Plugin: input.excel
            Reporter: Masato Nagai


I created patch to resolve empty cell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-998) I created patch to resolve empty cell.

Posted by "Masato Nagai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Masato Nagai updated FOR-998:
-----------------------------

    Attachment: table-to-document.xsl

See "Resolve empty cells" part.

> I created patch to resolve empty cell.
> --------------------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: table-to-document.xsl
>
>
> I created patch to resolve empty cell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-998) [PATCH] Resolve empty cells.

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576817#action_12576817 ] 

Thorsten Scherler commented on FOR-998:
---------------------------------------

Where has to go the attached file. 

Please next time create a diff patch that makes applying it lots easier.

> [PATCH] Resolve empty cells.
> ----------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: screenshot-1.jpg, table-to-document.xsl
>
>
> I created patch to resolve empty cells. Please try it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-998) [PATCH] Resolve empty cells.

Posted by "Gavin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493902 ] 

Gavin commented on FOR-998:
---------------------------

Hi Masato, thanks for the patch. I'm personally not sure if this correct though, it looks fine as it is.

In other words, the 'Spaces in Empty Cells' table does what it is supposed to, it has spaces in empty cells.
The other table 'Missing Spaces' also looks like it should - the spaces are missing !!, by design, as an example.

Your patch seems to put back spaces into te 'missing spaces' table and they are not supposed to be there.

Unless I misinterpreted the patch.

> [PATCH] Resolve empty cells.
> ----------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: screenshot-1.jpg, table-to-document.xsl
>
>
> I created patch to resolve empty cells. Please try it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-998) [PATCH] Resolve empty cells.

Posted by "Masato Nagai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Masato Nagai updated FOR-998:
-----------------------------

    Description: I created patch to resolve empty cells. Please try it.  (was: I created patch to resolve empty cell. Please try it.)

> [PATCH] Resolve empty cells.
> ----------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: screenshot-1.jpg, table-to-document.xsl
>
>
> I created patch to resolve empty cells. Please try it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-998) I created patch to resolve empty cell.

Posted by "Masato Nagai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Masato Nagai updated FOR-998:
-----------------------------

    Attachment: screenshot-1.jpg

See "Missing spaces" table.

> I created patch to resolve empty cell.
> --------------------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: screenshot-1.jpg, table-to-document.xsl
>
>
> I created patch to resolve empty cell.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FOR-998) [PATCH] Resolve empty cells.

Posted by "Masato Nagai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Masato Nagai updated FOR-998:
-----------------------------

    Description: I created patch to resolve empty cell. Please try it.  (was: I created patch to resolve empty cell.)
        Summary: [PATCH] Resolve empty cells.  (was: I created patch to resolve empty cell.)

> [PATCH] Resolve empty cells.
> ----------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: screenshot-1.jpg, table-to-document.xsl
>
>
> I created patch to resolve empty cell. Please try it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FOR-998) [PATCH] Resolve empty cells.

Posted by "Masato Nagai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FOR-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493908 ] 

Masato Nagai commented on FOR-998:
----------------------------------

Hi Gavin, thank you for the comment.

I think the "Missing Spaces" is problem. Because Excel doesn't output <ss:Cell> of empty cells, so can't create "Spaces in Empty Cells" table without preoperation, adding <ss:Cell> of empty cells. And This patch is to resolve it.

Do I misunderstand the requirement...?







> [PATCH] Resolve empty cells.
> ----------------------------
>
>                 Key: FOR-998
>                 URL: https://issues.apache.org/jira/browse/FOR-998
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: input.excel
>            Reporter: Masato Nagai
>         Attachments: screenshot-1.jpg, table-to-document.xsl
>
>
> I created patch to resolve empty cells. Please try it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.