You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "vinayakumarb (via GitHub)" <gi...@apache.org> on 2025/06/11 08:54:12 UTC
[PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
vinayakumarb opened a new pull request, #2267:
URL: https://github.com/apache/zookeeper/pull/2267
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #2267:
URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-2967244173
The change seems simple enough, and beneficial, but do you know the justification for making it final in the first place? Will this introduce some regression because it fails to consider that original justification?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2267:
URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-2978859022
Hi @vinayakumarb, does apache/curator#1252 solves your concerns ?
> do you know the justification for making it final in the first place?
I think it is because both `void shutdown()` and `void shutdown(boolean fullyShutDown)` are open to be overrode before the fix bc9afbf8ef1bc6156643d3d05c87fcf8411e9d8f to efbd660e1c4b90a8f538f2cccb5dcb7094cf9a22 which calls `shutdown(boolean fullyShutDown)` directly and bypass overrides in `shutdown()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
Posted by "vinayakumarb (via GitHub)" <gi...@apache.org>.
vinayakumarb commented on PR #2267:
URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-2988789685
> The change seems simple enough, and beneficial, but do you know the justification for making it final in the first place? Will this introduce some regression because it fails to consider that original justification?
There was no justification provided while making it final in the commit.
This change as been done in a subminor version release and broken Curator's TestingZookeeperMain class. Because of this, upgrading to zookeeper 3.9.3 is blocked, which breaks the tests which are using `TestingZookeeperMain` from curator.
in general, breaking changes are not advised in a subminor version. I totally agree that, `shutdown()` is not an API, but this change stops from adoption immediately.
Change https://github.com/apache/curator/pull/1252 would solve the problem. But that needs a release from Curator and down streams needs to adopt that as well which are not as frequent as zookeeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2267:
URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-2995212466
> breaking changes are not advised in a subminor version. I totally agree that, shutdown() is not an API, but this change stops from adoption immediately.
[ZooKeeperServerEmbedded](https://zookeeper.apache.org/doc/r3.9.3/apidocs/zookeeper-server/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbedded.html) was designed to be public in mind. Curator has migrated to it but it still have source code level dependencies on `ZooKeeperServer`.
> There was no justification provided while making it final in the commit.
My cents:
1. `void shutdown()` was changed to `final` to fix ZOOKEEPER-4712.
2. I would like `void shutdown(boolean fullyShutDown)` to be internal usages.
3. `void shutdownComponents()` should be used instead above two.
> Change https://github.com/apache/curator/pull/1252 would solve the problem. But that needs a release from Curator and down streams needs to adopt that as well which are not as frequent as zookeeper.
This is a compilation error, people will have to upgrade either curator or zookeeper anyway. I started a discuss to release a curator version for this: https://lists.apache.org/thread/jywgcrk11whh8km7q6btc6k574vx1lrq
Given above, it would be -0 from my side to make `void shutdown(boolean fullyShutDown)` non final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #2267:
URL: https://github.com/apache/zookeeper/pull/2267#issuecomment-3124438864
Apache Curator 5.9.0 has been released. https://lists.apache.org/thread/70st1k9wpkg6fkxt2xymolkpqt25fp4r
If anyone is using `ZookeeperServer` directly, I recommend they to migrate to:
1. `void shutdownComponents()` to release extra resources.
2. [ZooKeeperServerEmbedded](https://zookeeper.apache.org/doc/r3.9.3/apidocs/zookeeper-server/org/apache/zookeeper/server/embedded/ZooKeeperServerEmbedded.html) is designed for public usage.
Thank you all for contribution and participation! I am going to close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain [zookeeper]
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw closed pull request #2267: ZOOKEEPER-4936 - Make ZookeeperServer.shutdown(fullyShutdown) Non-final fix curator's TestingZookeeperMain
URL: https://github.com/apache/zookeeper/pull/2267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org