You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/09 19:11:59 UTC

[GitHub] brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix)

brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix)
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437464175
 
 
   Reopening as a WIP PR for now. I will take another look over the weekend.
   
   I think PR #539 should be merged by itself, keeping the commits here for now since they are needed to help resolve GH-540.
   
   A side point is that I did not see any test updates for CB-14125 (unit tests pass whether I keep or revert CB-14125 in my local workarea). Please correct me if I am mistaken. I think tests are really needed to help ensure it does not break in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org