You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/01 02:38:23 UTC

[GitHub] [kafka] dengziming opened a new pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

dengziming opened a new pull request #9664:
URL: https://github.com/apache/kafka/pull/9664


   *More detailed description of your change*
   The #9662 rewrite FeatureZNode struct with auto-generated protocol, but it's a non-trivial change, so we can just review this simple pr first.
   
   *Summary of testing strategy (including rationale)*
   unit test
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9664:
URL: https://github.com/apache/kafka/pull/9664#issuecomment-736217128


   Hi, @abbccdda PTAL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9664:
URL: https://github.com/apache/kafka/pull/9664#issuecomment-736255004


   @ijuma Thank you, I ignored this fact. 
   Some of the ZkNode will be removed because we no longer need them after KIP-500, for example `IsrChangeNotificationZNode` and `ControllerZNode`, however Some ZkNode will just be moved from ZkNode to RaftKafkaMetadataLog , for example `TopicZNode` and `FeatureZNode`.
   So can we still rewrite their struct use auto-generated protocol which can also be used after KIP-500? also ping @abbccdda as this is a major direction discussion.
   I will close this pr and create another for `TopicZNode` if you think it's reasonable, Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming closed pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #9664:
URL: https://github.com/apache/kafka/pull/9664


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9664:
URL: https://github.com/apache/kafka/pull/9664#issuecomment-736240488


   Thanks for the PR. I don't think we should do this since KIP-500 will replace all this code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org