You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2018/04/10 20:26:58 UTC

[GitHub] aharui closed pull request #147: GridColumnInfo GridRowInfo

aharui closed pull request #147: GridColumnInfo GridRowInfo
URL: https://github.com/apache/royale-asjs/pull/147
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridColumnInfo.as b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridColumnInfo.as
index 2fb49c0bf..0a6bf2283 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridColumnInfo.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridColumnInfo.as
@@ -29,6 +29,7 @@ import mx.core.UIComponent;
  *  @private
  *  Internal helper class used to exchange information between
  *  Grid and GridRow.
+ *  @royalesuppresspublicvarwarning
  */
 public class GridColumnInfo extends FlexChildInfo
 {
@@ -46,7 +47,7 @@ public class GridColumnInfo extends FlexChildInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
 	public function GridColumnInfo()
 	{
@@ -76,18 +77,10 @@ public class GridColumnInfo extends FlexChildInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _x:Number;
-	public function set x(value:Number):void
-	{
-	_x = value;
-	}
+	public var x:Number;
 	
-	public function get x():Number
-	{
-	return _x;
-	}
 	
 }
 
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridRowInfo.as b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridRowInfo.as
index 036947550..dbb10ccea 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridRowInfo.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/containers/gridClasses/GridRowInfo.as
@@ -28,7 +28,9 @@ import mx.core.UIComponent;
  *  @private
  *  Internal helper class used to exchange information between
  *  Grid and GridRow.
+ *  @royalesuppresspublicvarwarning
  */
+
 public class GridRowInfo
 {
 	/* include "../../core/Version.as";
@@ -45,16 +47,16 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
 	public function GridRowInfo()
 	{
 		super();
 
-		_min = 0;
-		_preferred = 0;
-		_max = UIComponent.DEFAULT_MAX_HEIGHT;
-		_flex = 0;
+		min = 0;
+		preferred = 0;
+		max = UIComponent.DEFAULT_MAX_HEIGHT;
+		flex = 0;
 	}
 	
 	//--------------------------------------------------------------------------
@@ -73,18 +75,10 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _flex:Number;
-	public function set flex(value:Number):void
-	{
-	_flex = value;
-	}
+	public var flex:Number;
 	
-	public function get flex():Number
-	{
-	return _flex;
-	}
 	//----------------------------------
 	//  height
 	//----------------------------------
@@ -96,18 +90,10 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _height:Number;
-	public function set height(value:Number):void
-	{
-	_height = value;
-	}
+	public var height:Number;
 	
-	public function get height():Number
-	{
-	return _height;
-	}
 	//----------------------------------
 	//  max
 	//----------------------------------
@@ -118,18 +104,10 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _max:Number;
-	public function set max(value:Number):void
-	{
-	_max = value;
-	}
+	public var max:Number;
 	
-	public function get max():Number
-	{
-	return _max;
-	}
 	//----------------------------------
 	//  min
 	//----------------------------------
@@ -140,20 +118,12 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _min:Number;
-	public function set min(value:Number):void
-	{
-	_min = value;
-	}
+	public var min:Number;
 	
-	public function get min():Number
-	{
-	return _min;
-	}
 	//----------------------------------
-	//  _preferred
+	//  preferred
 	//----------------------------------
 
 	/**
@@ -162,18 +132,10 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _preferred:Number;
-	public function set preferred(value:Number):void
-	{
-	_preferred = value;
-	}
+	public var preferred:Number;
 	
-	public function get preferred():Number
-	{
-	return _preferred;
-	}
 	//----------------------------------
 	//  y
 	//----------------------------------
@@ -185,18 +147,10 @@ public class GridRowInfo
 	 *  @langversion 3.0
 	 *  @playerversion Flash 9
 	 *  @playerversion AIR 1.1
-	 *  @productversion Flex 3
+	 *  @productversion Royale 0.9.3
 	 */
-	private var _y:Number;
-	public function set y(value:Number):void
-	{
-	_y = value;
-	}
+	public var y:Number;
 	
-	public function get y():Number
-	{
-	return _y;
-	}
 }
 
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services