You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/08 10:10:32 UTC
[GitHub] [flink] wxplovecc opened a new pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
wxplovecc opened a new pull request #12035:
URL: https://github.com/apache/flink/pull/12035
What is the purpose of the change
This pull request makes `HadoopRecoverableFsDataOutputStream#revokeLeaseByFileSystem` support `ViewFileSystem` when using viewfs the `revokeLeaseByFileSystem` method will not wait the file Lease to revoke because of not instance of `DistributedFileSystem`
## Brief change log
- * resolve the real path and FileSystem of ViewFileSystem then wait to revoke the file lease
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wxplovecc commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
wxplovecc commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-632550443
@StephanEwen added some viewfilesystem test by HDFS minicluster, after test I found last commit was not work because of #11815 has mentioned and the `truncate` method also need resolved path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
}, {
"hash" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034",
"triggerID" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee47a56f30023b1eb3d087b44fb2eed58ec7075b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-633078631
Thank you for looking into the test.
Unfortunately, this PR now contains a very large amount of unrelated code format changes and we cannot review or merge it like that [1]. These re-formattings hide the real important changes, hide root causes for line changes, in the git history, etc. Please make sure your IDE does not auto-format classes on save or so. The PR must really include only the relevant changes, not unrelated additional changes.
[1] https://flink.apache.org/contributing/contribute-code.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
}, {
"hash" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034",
"triggerID" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"triggerType" : "PUSH"
}, {
"hash" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2075",
"triggerID" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"triggerType" : "PUSH"
}, {
"hash" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4785",
"triggerID" : "626098206",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 130967260e2e17cc2378f4a130a4f2f8745d9a12 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2075) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-629695726
Thank you for diagnosing this and suggesting this patch!
The patch looks good.
Any chance you could add a simple test that can verify this? Maybe extend the test that rund on the HDFS minicluster and wrap it in a viewFs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d07a0d67629303d83b2998ff1b43aa698c59c116 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
}, {
"hash" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034",
"triggerID" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"triggerType" : "PUSH"
}, {
"hash" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee47a56f30023b1eb3d087b44fb2eed58ec7075b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034)
* 130967260e2e17cc2378f4a130a4f2f8745d9a12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wxplovecc commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
wxplovecc commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-630006157
@StephanEwen Ok, I will try to add a test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
}, {
"hash" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034",
"triggerID" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"triggerType" : "PUSH"
}, {
"hash" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2075",
"triggerID" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 130967260e2e17cc2378f4a130a4f2f8745d9a12 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2075)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d07a0d67629303d83b2998ff1b43aa698c59c116 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #12035:
URL: https://github.com/apache/flink/pull/12035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d07a0d67629303d83b2998ff1b43aa698c59c116 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wxplovecc edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
wxplovecc edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-633196955
updated @StephanEwen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wxplovecc commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
wxplovecc commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-633196955
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
}, {
"hash" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d07a0d67629303d83b2998ff1b43aa698c59c116 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828)
* ee47a56f30023b1eb3d087b44fb2eed58ec7075b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wxplovecc commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
wxplovecc commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-626098206
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625870674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=828",
"triggerID" : "d07a0d67629303d83b2998ff1b43aa698c59c116",
"triggerType" : "PUSH"
}, {
"hash" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2034",
"triggerID" : "ee47a56f30023b1eb3d087b44fb2eed58ec7075b",
"triggerType" : "PUSH"
}, {
"hash" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2075",
"triggerID" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"triggerType" : "PUSH"
}, {
"hash" : "130967260e2e17cc2378f4a130a4f2f8745d9a12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4785",
"triggerID" : "626098206",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 130967260e2e17cc2378f4a130a4f2f8745d9a12 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2075) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12035: [FLINK-17569][FileSystemsems]support ViewFileSystem when wait lease revoke of hadoop filesystem
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12035:
URL: https://github.com/apache/flink/pull/12035#issuecomment-625745162
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d07a0d67629303d83b2998ff1b43aa698c59c116 (Fri May 08 10:13:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17569).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org