You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/05 09:45:19 UTC
[GitHub] [flink-table-store] SteNicholas opened a new pull request, #198: [FLINK-26936] Pushdown watermark to table store source
SteNicholas opened a new pull request, #198:
URL: https://github.com/apache/flink-table-store/pull/198
`TableStoreSource` could support to push down watermark, which should implement the interface `SupportsWatermarkPushDown`.
**The brief change log**
- `TableStoreSource` implements the `SupportsWatermarkPushDown` interface to apply the `WatermarkStrategy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #198: [FLINK-26936] Pushdown watermark to table store source
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #198:
URL: https://github.com/apache/flink-table-store/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #198: [FLINK-26936] Pushdown watermark to table store source
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #198:
URL: https://github.com/apache/flink-table-store/pull/198#discussion_r913691734
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java:
##########
@@ -68,6 +74,8 @@
@Nullable private Predicate predicate;
@Nullable private int[][] projectFields;
+ @Nullable private WatermarkStrategy<RowData> watermarkStrategy;
Review Comment:
Need copy it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #198: [FLINK-26936] Pushdown watermark to table store source
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #198:
URL: https://github.com/apache/flink-table-store/pull/198#discussion_r913691734
##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/TableStoreSource.java:
##########
@@ -68,6 +74,8 @@
@Nullable private Predicate predicate;
@Nullable private int[][] projectFields;
+ @Nullable private WatermarkStrategy<RowData> watermarkStrategy;
Review Comment:
Need copy it.
Can you introduce a constructor for `TableStoreSource`? Including predicate, projectFields and watermarkStrategy, in this way, it is better to avoid missing copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org