You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2026/04/02 12:29:46 UTC
[PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
BiteTheDDDDt opened a new pull request, #62056:
URL: https://github.com/apache/doris/pull/62056
This pull request improves the safety and clarity of the hash join build sink operator's handling of early termination and hash table signaling. The changes ensure that non-builder tasks do not attempt to access an uninitialized hash table, preventing potential crashes due to type mismatches.
Hash join build signaling and termination handling:
* In `HashJoinBuildSinkLocalState::close`, the builder task now sets `_signaled = true` only if it was not terminated early, ensuring that non-builder tasks do not attempt to access an uninitialized hash table. Additional comments clarify the logic and the relationship between `_terminated` and `_signaled`.
* In `HashJoinBuildSinkOperatorX::sink`, updated the logic and comments to clarify that non-builder tasks will return EOF if the builder has not finished or was terminated early, relying on the improved `_signaled` guard to prevent unsafe access to the hash table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181817661
# BE Regression && UT Coverage Report
Increment line coverage `93.16% (395/424)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.57% (27299/37105) |
| Line Coverage | 57.23% (294099/513922) |
| Region Coverage | 54.50% (245229/449977) |
| Branch Coverage | 56.16% (106249/189183) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181727449
# BE Regression && UT Coverage Report
Increment line coverage `93.16% (395/424)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.56% (27294/37105) |
| Line Coverage | 57.21% (293999/513922) |
| Region Coverage | 54.53% (245377/449977) |
| Branch Coverage | 56.16% (106254/189183) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181676995
# BE Regression && UT Coverage Report
Increment line coverage `87.50% (63/72)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.55% (27291/37105) |
| Line Coverage | 57.20% (293939/513922) |
| Region Coverage | 54.49% (245209/449977) |
| Branch Coverage | 56.14% (106207/189183) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4179315414
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/3ddbbef46a569623b164cd96c0ecc9c24a9669e9_3ddbbef46a569623b164cd96c0ecc9c24a9669e9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/3ddbbef46a569623b164cd96c0ecc9c24a9669e9_3ddbbef46a569623b164cd96c0ecc9c24a9669e9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.94% (20057/37885) |
| Line Coverage | 36.55% (188399/515492) |
| Region Coverage | 32.83% (146359/445838) |
| Branch Coverage | 33.97% (64063/188601) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4177609051
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #62056:
URL: https://github.com/apache/doris/pull/62056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #62056:
URL: https://github.com/apache/doris/pull/62056#discussion_r3027797950
##########
be/src/exec/operator/hashjoin_build_sink.cpp:
##########
@@ -237,7 +237,18 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState* state, Status exec_statu
if (p._use_shared_hash_table) {
std::unique_lock lock(p._mutex);
- p._signaled = true;
+ // Only signal non-builder tasks when the builder actually built the hash table.
+ // When the builder is terminated (woken up early because the probe side finished
+ // first), it never called process_build_block() so the hash table variant is still
+ // monostate. Setting _signaled=true in that case would cause non-builder tasks to
+ // enter std::visit on monostate and crash with "Hash table type mismatch".
+ //
+ // _terminated is reliably true here when the task was woken up early, because
+ // operator terminate() is called in the execute() Defer (pipeline_task.cpp:510-512)
+ // BEFORE close() runs.
Review Comment:
The new comment ties the correctness of the `_terminated` check to specific line numbers in `pipeline_task.cpp` ("pipeline_task.cpp:510-512"). Those line references are brittle and will become stale as the file evolves; consider referencing the function/logic instead (e.g., “in PipelineTask::execute() Defer”) or linking to a more stable invariant/flag rather than hard-coded line numbers.
```suggestion
// operator terminate() is called from the execute() Defer in PipelineTask
// before close() is invoked.
```
##########
be/src/exec/operator/hashjoin_build_sink.cpp:
##########
@@ -840,10 +851,18 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState* state, Block* in_block, bo
RETURN_IF_ERROR(local_state.build_asof_index(*local_state._shared_state->build_block));
local_state.init_short_circuit_for_probe();
} else if (!local_state._should_build_hash_table) {
- // the instance which is not build hash table, it's should wait the signal of hash table build finished.
- // but if it's running and signaled == false, maybe the source operator have closed caused by some short circuit
- // return eof will make task marked as wake_up_early
- // todo: remove signaled after we can guarantee that wake up eraly is always set accurately
+ // The non-builder instance waits for the builder (task 0) to finish building the hash table.
+ // If _signaled is false, either the builder hasn't finished yet, or the builder was
+ // terminated (woken up early) without building the hash table — in both cases, return EOF.
+ //
+ // The close() Defer in the builder conditionally sets _signaled=true ONLY when the builder
+ // was NOT terminated (i.e., the hash table was actually built). When the builder is
+ // terminated, _signaled stays false, so non-builders always hit this guard and return EOF
+ // safely — never reaching the std::visit on an uninitialized (monostate) hash table.
+ //
+ // _terminated is also checked as a secondary guard. Note that _terminated is always false
+ // inside sink() during execute() (it's set in the Defer AFTER execute() returns), so it
+ // provides no protection against the race. The _signaled check is the real guard.
if (!_signaled || local_state._terminated) {
return Status::Error<ErrorCode::END_OF_FILE>("source have closed");
Review Comment:
Typo/grammar in the END_OF_FILE message: "source have closed" should be "source has closed" (or a more specific message about waiting for the shared hash table). This string is user-visible in logs/errors and is currently ungrammatical.
```suggestion
return Status::Error<ErrorCode::END_OF_FILE>("source has closed");
```
##########
be/src/exec/operator/hashjoin_build_sink.cpp:
##########
@@ -840,10 +851,18 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState* state, Block* in_block, bo
RETURN_IF_ERROR(local_state.build_asof_index(*local_state._shared_state->build_block));
local_state.init_short_circuit_for_probe();
} else if (!local_state._should_build_hash_table) {
- // the instance which is not build hash table, it's should wait the signal of hash table build finished.
- // but if it's running and signaled == false, maybe the source operator have closed caused by some short circuit
- // return eof will make task marked as wake_up_early
- // todo: remove signaled after we can guarantee that wake up eraly is always set accurately
+ // The non-builder instance waits for the builder (task 0) to finish building the hash table.
+ // If _signaled is false, either the builder hasn't finished yet, or the builder was
+ // terminated (woken up early) without building the hash table — in both cases, return EOF.
+ //
+ // The close() Defer in the builder conditionally sets _signaled=true ONLY when the builder
+ // was NOT terminated (i.e., the hash table was actually built). When the builder is
+ // terminated, _signaled stays false, so non-builders always hit this guard and return EOF
+ // safely — never reaching the std::visit on an uninitialized (monostate) hash table.
+ //
+ // _terminated is also checked as a secondary guard. Note that _terminated is always false
+ // inside sink() during execute() (it's set in the Defer AFTER execute() returns), so it
+ // provides no protection against the race. The _signaled check is the real guard.
if (!_signaled || local_state._terminated) {
Review Comment:
The guard `if (!_signaled || local_state._terminated)` is now accompanied by a comment stating `_terminated` is always false inside `sink()` and provides no protection against the race. That makes the `local_state._terminated` part look redundant/confusing; consider either removing it or adjusting the comment to explain when `_terminated` can actually be true at this point.
```suggestion
// At this point, termination is reflected solely through the value of _signaled: a
// terminated builder never sets _signaled to true. Checking !_signaled is therefore
// sufficient and serves as the real guard against racing with an uninitialized hash table.
if (!_signaled) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4182628257
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4177528616
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4177528183
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4182628110
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181388920
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181564695
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/3ddbbef46a569623b164cd96c0ecc9c24a9669e9_3ddbbef46a569623b164cd96c0ecc9c24a9669e9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/3ddbbef46a569623b164cd96c0ecc9c24a9669e9_3ddbbef46a569623b164cd96c0ecc9c24a9669e9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.94% (20057/37885) |
| Line Coverage | 36.55% (188425/515492) |
| Region Coverage | 32.82% (146311/445838) |
| Branch Coverage | 33.97% (64066/188601) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62056:
URL: https://github.com/apache/doris/pull/62056#discussion_r3027854713
##########
be/src/exec/operator/hashjoin_build_sink.cpp:
##########
@@ -840,12 +851,20 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState* state, Block* in_block, bo
RETURN_IF_ERROR(local_state.build_asof_index(*local_state._shared_state->build_block));
local_state.init_short_circuit_for_probe();
} else if (!local_state._should_build_hash_table) {
- // the instance which is not build hash table, it's should wait the signal of hash table build finished.
- // but if it's running and signaled == false, maybe the source operator have closed caused by some short circuit
- // return eof will make task marked as wake_up_early
- // todo: remove signaled after we can guarantee that wake up eraly is always set accurately
- if (!_signaled || local_state._terminated) {
- return Status::Error<ErrorCode::END_OF_FILE>("source have closed");
+ // The non-builder instance waits for the builder (task 0) to finish building the hash table.
+ // If _signaled is false, either the builder hasn't finished yet, or the builder was
+ // terminated (woken up early) without building the hash table — in both cases, return EOF.
+ //
+ // The close() Defer in the builder conditionally sets _signaled=true ONLY when the builder
+ // was NOT terminated (i.e., the hash table was actually built). When the builder is
+ // terminated, _signaled stays false, so non-builders always hit this guard and return EOF
+ // safely — never reaching the std::visit on an uninitialized (monostate) hash table.
+ //
+ // At this point, termination is reflected solely through the value of _signaled: a
+ // terminated builder never sets _signaled to true. Checking !_signaled is therefore
+ // sufficient and serves as the real guard against racing with an uninitialized hash table.
+ if (!_signaled) {
Review Comment:
Please add coverage for this interleaving. The bug only reproduces when `enable_share_hash_table_for_broadcast_join=true`, task 0 is woken up early, and another build task reaches this `!_signaled` guard before trying to reuse the shared hash table. I could not find a new test for that path: `regression-test/suites/query_p0/join/test_terminate.groovy` exercises a shuffle join, and the existing `hashjoin_build_sink` BE tests only run `task_idx == 0`. Since this is a pipeline/kernel race fix, AGENTS.md requires a focused regression or unit test here so the crash does not silently come back in a later refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4178819993
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4177609820
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181625579
# BE Regression && UT Coverage Report
Increment line coverage `77.78% (14/18)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.55% (27291/37105) |
| Line Coverage | 57.20% (293939/513922) |
| Region Coverage | 54.49% (245209/449977) |
| Branch Coverage | 56.14% (106207/189183) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](pipeline) do not set shared hash table signaled when task terminated [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62056:
URL: https://github.com/apache/doris/pull/62056#issuecomment-4181797805
# BE Regression && UT Coverage Report
Increment line coverage `93.16% (395/424)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62056_3ddbbef46a569623b164cd96c0ecc9c24a9669e9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.56% (27295/37105) |
| Line Coverage | 57.21% (294004/513922) |
| Region Coverage | 54.53% (245355/449977) |
| Branch Coverage | 56.17% (106255/189183) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org