You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@beam.apache.org by Sam Whittle <sa...@google.com> on 2020/11/02 11:40:25 UTC

Reviewer for core-java runner bug fixes?

Hi,
I'm looking for a reviewer for several core-java runner bug fixes around
triggers. I assigned to klk@ as it appeared he last modified but I imagine
he's got a lot on his plate. Anyone else familiar with this code?

AfterPane state leak for late triggers
https://github.com/apache/beam/pull/13206

Incorrect state prefetching for subtriggers
https://github.com/apache/beam/pull/13221

Thanks!

Re: Reviewer for core-java runner bug fixes?

Posted by Rui Wang <ru...@google.com>.

I am not an expert on triggers. But I will try to help review the code.


-Rui

On Mon, Nov 2, 2020 at 3:40 AM Sam Whittle <sa...@google.com> wrote:

> Hi,
> I'm looking for a reviewer for several core-java runner bug fixes around
> triggers. I assigned to klk@ as it appeared he last modified but I
> imagine he's got a lot on his plate. Anyone else familiar with this code?
>
> AfterPane state leak for late triggers
> https://github.com/apache/beam/pull/13206
>
> Incorrect state prefetching for subtriggers
> https://github.com/apache/beam/pull/13221
>
> Thanks!
>

Re: Reviewer for core-java runner bug fixes?

Posted by Deepak Vohra <dv...@yahoo.com>.

 Would a reviewer need to test bug fixes? thanks, Deepak
    On Monday, November 2, 2020, 03:40:49 a.m. PST, Sam Whittle <sa...@google.com> wrote:  
 
 Hi,I'm looking for a reviewer for several core-java runner bug fixes around triggers. I assigned to klk@ as it appeared he last modified but I imagine he's got a lot on his plate. Anyone else familiar with this code?
AfterPane state leak for late triggershttps://github.com/apache/beam/pull/13206

Incorrect state prefetching for subtriggershttps://github.com/apache/beam/pull/13221

Thanks!