You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xylaaaaa (via GitHub)" <gi...@apache.org> on 2026/01/12 10:30:51 UTC
[PR] [feat] integrate paimon-cpp library and add demo tool [doris]
xylaaaaa opened a new pull request, #59787:
URL: https://github.com/apache/doris/pull/59787
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat] integrate paimon-cpp library and add demo tool [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59787:
URL: https://github.com/apache/doris/pull/59787#issuecomment-3737860352
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat] integrate paimon-cpp library and add demo tool [doris]
Posted by "xylaaaaa (via GitHub)" <gi...@apache.org>.
xylaaaaa closed pull request #59787: [feat] integrate paimon-cpp library and add demo tool
URL: https://github.com/apache/doris/pull/59787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat] integrate paimon-cpp library and add demo tool [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #59787:
URL: https://github.com/apache/doris/pull/59787#discussion_r2681804174
##########
be/src/tools/paimon_cpp_demo.cpp:
##########
@@ -0,0 +1,10 @@
+// Minimal Paimon C++ link/ABI check for Doris BE.
Review Comment:
Missing Apache license header. All source files in this project should include the standard Apache License 2.0 header at the beginning of the file, consistent with other tool files like meta_tool.cpp and packed_file_tool.cpp.
##########
be/CMakeLists.txt:
##########
@@ -146,6 +146,15 @@ message(STATUS "build task executor simulator: ${BUILD_TASK_EXECUTOR_SIMULATOR}"
option(BUILD_FILE_CACHE_LRU_TOOL "ON for building file cache lru tool or OFF for not" OFF)
message(STATUS "build file cache lru tool: ${BUILD_FILE_CACHE_LRU_TOOL}")
+if (DEFINED ENV{ENABLE_PAIMON_CPP})
+ set(ENABLE_PAIMON_CPP "$ENV{ENABLE_PAIMON_CPP}")
+endif()
+option(ENABLE_PAIMON_CPP "Enable Paimon C++ integration" OFF)
Review Comment:
Missing status message for ENABLE_PAIMON_CPP option. Following the pattern of other build options in this file (BUILD_FS_BENCHMARK, BUILD_TASK_EXECUTOR_SIMULATOR, BUILD_FILE_CACHE_LRU_TOOL), there should be a message statement after the option declaration to log the configuration status, similar to: message(STATUS "enable paimon cpp: ${ENABLE_PAIMON_CPP}")
```suggestion
option(ENABLE_PAIMON_CPP "Enable Paimon C++ integration" OFF)
message(STATUS "enable paimon cpp: ${ENABLE_PAIMON_CPP}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org