You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/17 11:58:46 UTC

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18812: [FLINK-25129][docs] Improvements to the table-planner-loader related docs

slinkydeveloper commented on a change in pull request #18812:
URL: https://github.com/apache/flink/pull/18812#discussion_r808972507



##########
File path: docs/content/docs/dev/table/sourcesSinks.md
##########
@@ -120,12 +120,18 @@ a DataStream connector to the Table API), you need to add this dependency:
 
 {{< artifact flink-table-api-java-bridge withProvidedScope >}}
 
-When shipping the connector/format, we suggest providing both a thin JAR and an uber JAR. This way, 
-users can easily load the uber JAR in the SQL client or in the Flink distribution and start using it.
-
-**Note:** None of the table dependencies listed above should be packaged in the uber JAR since they 
-are already provided by the Flink distribution.
-
+When developing the connector/format, we suggest shipping both a thin JAR and an uber JAR. 
+In particular, the uber JAR should include all the 3rd party dependencies of the connector, excluding the table dependencies listed above.

Review comment:
       WDYM by line breaks? just one break for improving the markdown source, or two line breaks to add the empty line between text blocks?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org