You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2015/08/25 14:34:46 UTC
[27/50] incubator-tinkerpop git commit: Removed gephi viz of ALL
filters.
Removed gephi viz of ALL filters.
Narrowed visualization just down to HasStep (previously FilterStep). When using FilterStep extra decay of colors was happening in gephi when used with loops. Don't think that was desireable.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/86402aba
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/86402aba
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/86402aba
Branch: refs/heads/tp30
Commit: 86402aba9b464aca534cf7176e26a36573cece28
Parents: 6935322
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Mon Aug 17 09:20:47 2015 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Mon Aug 17 09:20:47 2015 -0400
----------------------------------------------------------------------
.../console/plugin/GephiTraversalVisualizationStrategy.groovy | 7 +++++--
.../groovy/plugin/GephiRemoteAcceptorIntegrateTest.java | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/86402aba/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/plugin/GephiTraversalVisualizationStrategy.groovy
----------------------------------------------------------------------
diff --git a/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/plugin/GephiTraversalVisualizationStrategy.groovy b/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/plugin/GephiTraversalVisualizationStrategy.groovy
index d78b535..661d2ff 100644
--- a/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/plugin/GephiTraversalVisualizationStrategy.groovy
+++ b/gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/plugin/GephiTraversalVisualizationStrategy.groovy
@@ -25,6 +25,7 @@ import org.apache.tinkerpop.gremlin.process.traversal.TraversalStrategy
import org.apache.tinkerpop.gremlin.process.traversal.Traverser
import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__
import org.apache.tinkerpop.gremlin.process.traversal.step.filter.FilterStep
+import org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasStep
import org.apache.tinkerpop.gremlin.process.traversal.step.map.EdgeOtherVertexStep
import org.apache.tinkerpop.gremlin.process.traversal.step.map.EdgeVertexStep
import org.apache.tinkerpop.gremlin.process.traversal.step.map.FoldStep
@@ -100,8 +101,10 @@ class GephiTraversalVisualizationStrategy extends AbstractTraversalStrategy<Trav
}
// decay all vertices except those that made it through the filter - "this way you can watch
- // the Gremlins dying" - said daniel kuppitz
- TraversalHelper.getStepsOfAssignableClass(FilterStep.class, traversal).each { FilterStep s ->
+ // the Gremlins dying" - said daniel kuppitz. can't do this easily with generic FilterStep as
+ // it creates odd behaviors when used with loop (extra decay that probably shouldn't be there.
+ // todo: can this be better? maybe we shouldn't do this at all
+ TraversalHelper.getStepsOfAssignableClass(HasStep.class, traversal).each { HasStep s ->
TraversalHelper.insertAfterStep(new LambdaSideEffectStep(traversal, { Traverser traverser ->
final BulkSet<Object> objects = ((BulkSet<Object>) traverser.sideEffects(sideEffectKey))
if (!objects.isEmpty()) {
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/86402aba/gremlin-console/src/test/java/org/apache/tinkerpop/gremlin/console/groovy/plugin/GephiRemoteAcceptorIntegrateTest.java
----------------------------------------------------------------------
diff --git a/gremlin-console/src/test/java/org/apache/tinkerpop/gremlin/console/groovy/plugin/GephiRemoteAcceptorIntegrateTest.java b/gremlin-console/src/test/java/org/apache/tinkerpop/gremlin/console/groovy/plugin/GephiRemoteAcceptorIntegrateTest.java
index cb23798..79a7997 100644
--- a/gremlin-console/src/test/java/org/apache/tinkerpop/gremlin/console/groovy/plugin/GephiRemoteAcceptorIntegrateTest.java
+++ b/gremlin-console/src/test/java/org/apache/tinkerpop/gremlin/console/groovy/plugin/GephiRemoteAcceptorIntegrateTest.java
@@ -179,7 +179,7 @@ public class GephiRemoteAcceptorIntegrateTest {
acceptor.submit(Arrays.asList(
"vg.V(1).repeat(org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.__().out()).times(2).iterate()"));
- wireMockRule.verify(23, postRequestedFor(urlPathEqualTo("/workspace0")));
+ wireMockRule.verify(13, postRequestedFor(urlPathEqualTo("/workspace0")));
}
@Test