You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Daniel Niklas (JIRA)" <de...@myfaces.apache.org> on 2010/09/10 17:19:34 UTC
[jira] Created: (TRINIDAD-1910) portal: common.js is included
serveral times
portal: common.js is included serveral times
--------------------------------------------
Key: TRINIDAD-1910
URL: https://issues.apache.org/jira/browse/TRINIDAD-1910
Project: MyFaces Trinidad
Issue Type: Bug
Components: Portlet
Affects Versions: 1.0.10-core
Reporter: Daniel Niklas
The commons.js is included several times, when you have more than one trinidad-porlet on your portal-site.
In XhtmlUtils#writeLibImport there is a mechanism to prevent including javascript libs more than one time (portal environment). This mechanism is not working, when you have more than one Trinidad-portlets within different web apps.
The problem is, that the key contains the webapp context!
Here " _uixJSL" for example contains:
"/webapp-one/adf/jsLibs/Common1_0_10.js"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1910) portal: common.js is included
serveral times
Posted by "Daniel Niklas (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909200#action_12909200 ]
Daniel Niklas commented on TRINIDAD-1910:
-----------------------------------------
one more comment:
this patch only works for portlets using the dame trinidad version!
> portal: common.js is included serveral times
> --------------------------------------------
>
> Key: TRINIDAD-1910
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1910
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Portlet
> Affects Versions: 1.0.10-core
> Reporter: Daniel Niklas
> Attachments: XhtmlUtils-patch.txt
>
>
> The commons.js is included several times, when you have more than one trinidad-porlet on your portal-site.
> In XhtmlUtils#writeLibImport there is a mechanism to prevent including javascript libs more than one time (portal environment). This mechanism is not working, when you have more than one Trinidad-portlets within different web apps.
> The problem is, that the key contains the webapp context!
> Here " _uixJSL" for example contains:
> "/webapp-one/adf/jsLibs/Common1_0_10.js"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1910) portal: common.js is included
serveral times
Posted by "Daniel Niklas (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908056#action_12908056 ]
Daniel Niklas commented on TRINIDAD-1910:
-----------------------------------------
One comment to my patch:
I could not find constants for "adf/jsfLibs"; "Configuration" seems to be outdated?!
> portal: common.js is included serveral times
> --------------------------------------------
>
> Key: TRINIDAD-1910
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1910
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Portlet
> Affects Versions: 1.0.10-core
> Reporter: Daniel Niklas
> Attachments: XhtmlUtils-patch.txt
>
>
> The commons.js is included several times, when you have more than one trinidad-porlet on your portal-site.
> In XhtmlUtils#writeLibImport there is a mechanism to prevent including javascript libs more than one time (portal environment). This mechanism is not working, when you have more than one Trinidad-portlets within different web apps.
> The problem is, that the key contains the webapp context!
> Here " _uixJSL" for example contains:
> "/webapp-one/adf/jsLibs/Common1_0_10.js"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1910) portal: common.js is included
serveral times
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910774#action_12910774 ]
Scott O'Bryan commented on TRINIDAD-1910:
-----------------------------------------
Yeah, at most this is a stop gap.. What really needs to happen here is either:
1. namespacing of the trinidad javascripts (which there is another JIRA ticket for) or
2. proving some sort of javascipt versioning with a JS loader.
The first would provide version isolation when portlets are inlined, the second is a lot harder but would provide us a single library being loaded per version. I'm not sure what the right solution would be,.
> portal: common.js is included serveral times
> --------------------------------------------
>
> Key: TRINIDAD-1910
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1910
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Portlet
> Affects Versions: 1.0.10-core
> Reporter: Daniel Niklas
> Attachments: XhtmlUtils-patch.txt
>
>
> The commons.js is included several times, when you have more than one trinidad-porlet on your portal-site.
> In XhtmlUtils#writeLibImport there is a mechanism to prevent including javascript libs more than one time (portal environment). This mechanism is not working, when you have more than one Trinidad-portlets within different web apps.
> The problem is, that the key contains the webapp context!
> Here " _uixJSL" for example contains:
> "/webapp-one/adf/jsLibs/Common1_0_10.js"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1910) portal: common.js is included
serveral times
Posted by "Daniel Niklas (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908053#action_12908053 ]
Daniel Niklas commented on TRINIDAD-1910:
-----------------------------------------
Keep TRINIDAD-53 and TRINIDAD-1705 in mind, this would work, too. The solution for this issues is probably a lot of work...
> portal: common.js is included serveral times
> --------------------------------------------
>
> Key: TRINIDAD-1910
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1910
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Portlet
> Affects Versions: 1.0.10-core
> Reporter: Daniel Niklas
>
> The commons.js is included several times, when you have more than one trinidad-porlet on your portal-site.
> In XhtmlUtils#writeLibImport there is a mechanism to prevent including javascript libs more than one time (portal environment). This mechanism is not working, when you have more than one Trinidad-portlets within different web apps.
> The problem is, that the key contains the webapp context!
> Here " _uixJSL" for example contains:
> "/webapp-one/adf/jsLibs/Common1_0_10.js"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1910) portal: common.js is included
serveral times
Posted by "Daniel Niklas (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Niklas updated TRINIDAD-1910:
------------------------------------
Status: Patch Available (was: Open)
> portal: common.js is included serveral times
> --------------------------------------------
>
> Key: TRINIDAD-1910
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1910
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Portlet
> Affects Versions: 1.0.10-core
> Reporter: Daniel Niklas
>
> The commons.js is included several times, when you have more than one trinidad-porlet on your portal-site.
> In XhtmlUtils#writeLibImport there is a mechanism to prevent including javascript libs more than one time (portal environment). This mechanism is not working, when you have more than one Trinidad-portlets within different web apps.
> The problem is, that the key contains the webapp context!
> Here " _uixJSL" for example contains:
> "/webapp-one/adf/jsLibs/Common1_0_10.js"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.