You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/29 13:46:53 UTC

[GitHub] [shardingsphere] Jacob953 commented on pull request #21431: Dynamic Loading SQL Parser Parameterized Test

Jacob953 commented on PR #21431:
URL: https://github.com/apache/shardingsphere/pull/21431#issuecomment-1295841634

   Implement steps:
   - Get all `download_url`s of SQL case files via github-api at once through getTestParameters.
   - Append each SQL ended up with `;` and ID, which is generated by the SQL case file and case number, to an array.
   - Pass the array to assertDynamicLoadingSQL at DynamicLoading(MySQL/PostgreSQL)ParserParameterizedTest.
   - Each SQL will go through the parsing engine
       - if successful, the case would pass at `new SQLVisitorEngine`.
       - else, print id, value, and db-type of SQL and throw non-RuntimeException to make the test case pass with @SingletonSPI
   <img width="1338" alt="image" src="https://user-images.githubusercontent.com/64075563/198834803-094a3b35-330c-431a-aa22-6a75777e716f.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org