You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "Yohahaha (via GitHub)" <gi...@apache.org> on 2026/05/22 09:23:58 UTC
[PR] [spark] Allow specific plugin impl can use catalog config to overwrite default table prop [fluss]
Yohahaha opened a new pull request, #3364:
URL: https://github.com/apache/fluss/pull/3364
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Brief change log
as title.
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Allow specific plugin impl can use catalog config to overwrite default table prop [fluss]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3364:
URL: https://github.com/apache/fluss/pull/3364#discussion_r3287382547
##########
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakeUtils.scala:
##########
@@ -25,17 +25,25 @@ import org.apache.fluss.utils.PropertiesUtils
import java.util
+import scala.collection.JavaConverters._
+
object FlussLakeUtils {
+ private val SPARK_CATALOG_PREFIX = "spark.catalog."
Review Comment:
`SPARK_CATALOG_PREFIX` is set to `spark.catalog.` but Spark’s catalog plugin configuration keys are `spark.sql.catalog.*` (see e.g. FlussSparkTestBase and website docs). With the current prefix, lake storage plugins that expect Spark catalog configs won’t be able to discover them. Consider switching to `spark.sql.catalog.` (and ensuring keys are constructed in the same shape Spark expects).
##########
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakeUtils.scala:
##########
@@ -25,17 +25,25 @@ import org.apache.fluss.utils.PropertiesUtils
import java.util
+import scala.collection.JavaConverters._
+
object FlussLakeUtils {
+ private val SPARK_CATALOG_PREFIX = "spark.catalog."
+
def createLakeSource(
+ catalogProperties: util.Map[String, String],
tableProperties: util.Map[String, String],
tablePath: TablePath): LakeSource[LakeSplit] = {
val tableConfig = Configuration.fromMap(tableProperties)
val datalakeFormat = tableConfig.get(ConfigOptions.TABLE_DATALAKE_FORMAT)
val dataLakePrefix = "table.datalake." + datalakeFormat + "."
- val catalogProperties = PropertiesUtils.extractAndRemovePrefix(tableProperties, dataLakePrefix)
- val lakeConfig = Configuration.fromMap(catalogProperties)
+ val lakeConfig =
+ Configuration.fromMap(PropertiesUtils.extractAndRemovePrefix(tableProperties, dataLakePrefix))
+ catalogProperties.asScala.foreach {
+ case (k, v) => lakeConfig.setString(s"$SPARK_CATALOG_PREFIX$k", v)
+ }
Review Comment:
This change forwards catalog properties into `lakeConfig` to enable overriding table defaults, but there’s no unit/integration test asserting that catalog-provided configs actually take precedence over `table.datalake.<format>.*` values. Adding a Spark lake read UT that sets conflicting values via catalog options and verifies the plugin observes the catalog value would prevent regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Allow specific plugin impl can use catalog config to overwrite default table prop [fluss]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on code in PR #3364:
URL: https://github.com/apache/fluss/pull/3364#discussion_r3288090508
##########
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/read/lake/FlussLakeUtils.scala:
##########
@@ -25,17 +25,25 @@ import org.apache.fluss.utils.PropertiesUtils
import java.util
+import scala.collection.JavaConverters._
+
object FlussLakeUtils {
+ private val SPARK_CATALOG_PREFIX = "spark.catalog."
Review Comment:
we already extract spark catalog prefix when construct FlussTable, but comments here LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Allow specific plugin impl can use catalog config to overwrite default table prop [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #3364:
URL: https://github.com/apache/fluss/pull/3364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Allow specific plugin impl can use catalog config to overwrite default table prop [fluss]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on PR #3364:
URL: https://github.com/apache/fluss/pull/3364#issuecomment-4517399696
@YannByron @luoyuxia PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] Allow specific plugin impl can use catalog config to overwrite default table prop [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #3364:
URL: https://github.com/apache/fluss/pull/3364#issuecomment-4518310921
@Yohahaha lgtm overall. Please take care of the comments of copilot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org