[GitHub] [flink] wangyang0918 commented on a change in pull request #11639: [FLINK-16626][runtime] Prevent REST handler from being closed more than once

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #11639: [FLINK-16626][runtime] Prevent REST handler from being closed more than once
URL: https://github.com/apache/flink/pull/11639#discussion_r405267276
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java
 ##########
 @@ -221,7 +227,12 @@ private void finalizeRequestProcessing(FileUploads uploadedFiles) {
 
 	@Override
 	public final CompletableFuture<Void> closeAsync() {
-		return FutureUtils.composeAfterwards(closeHandlerAsync(), inFlightRequestTracker::awaitAsync);
+		if (isHandlerClosed.compareAndSet(false, true)) {
+			return FutureUtils.composeAfterwards(closeHandlerAsync(), inFlightRequestTracker::awaitAsync);
+		} else {
+			log.warn("The handler instance for {} had already been closed, but another attempt at closing it was made.", untypedResponseMessageHeaders.getTargetRestEndpointURL());
+			return CompletableFuture.completedFuture(null);
 
 Review comment:
   I am not sure whether we need to add such logics here. Since the `closeAsync` is not designed to be called multiple times and also currently we do not have this behavior. We close the handler one by one in `RestEndpoint#closeHandlersAsync`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services