You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "sakthivelmanii (via GitHub)" <gi...@apache.org> on 2026/01/27 16:40:56 UTC

[PR] Upgrade Spanner to the latest version [beam]

sakthivelmanii opened a new pull request, #37433:
URL: https://github.com/apache/beam/pull/37433

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2734805716


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java:
##########
@@ -57,14 +57,14 @@ public void testCreateOnlyOnce() {
     SpannerAccessor acc2 = SpannerAccessor.getOrCreate(config1);
     SpannerAccessor acc3 = SpannerAccessor.getOrCreate(config1);
 
-    acc1.close();
-    acc2.close();
-    acc3.close();
+    // acc1.close();

Review Comment:
   I am trying to reproduce the hanging issue that we faced in 6.105.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3840570254

   Assigning reviewers:
   
   R: @ahmedabu98 for label java.
   R: @damccorm for label build.
   R: @nielm for label spanner.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3853985493

   I had to rebase my branch with the latest master to make spotless tests to pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "bharadwaj-aditya (via GitHub)" <gi...@apache.org>.
bharadwaj-aditya commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2734783904


##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java:
##########
@@ -57,14 +57,14 @@ public void testCreateOnlyOnce() {
     SpannerAccessor acc2 = SpannerAccessor.getOrCreate(config1);
     SpannerAccessor acc3 = SpannerAccessor.getOrCreate(config1);
 
-    acc1.close();
-    acc2.close();
-    acc3.close();
+    // acc1.close();

Review Comment:
   Is this not required anymore ? If it is not, please remove it rather than comment it out



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java:
##########
@@ -389,4 +393,20 @@ public SpannerConfig withUsingPlainTextChannel(ValueProvider<Boolean> plainText)
   public SpannerConfig withUsingPlainTextChannel(boolean plainText) {
     return withUsingPlainTextChannel(ValueProvider.StaticValueProvider.of(plainText));
   }
+
+  /**
+   * @param waitForMinSessionsDuration
+   * @return {@link SpannerConfig}
+   *
+   * Sets the wait time for multiplexed session to be available while creating a database client.
+   * Setting this will block the {@link com.google.cloud.spanner.DatabaseClient} creation. By default,
+   * We will be setting 5 mins as minimum wait time.
+   */
+  public SpannerConfig withWaitForMinSessionsDuration(ValueProvider<java.time.Duration> waitForMinSessionsDuration) {

Review Comment:
   naming nit: This is the wait for a session to be created. Min sessions seems to suggest a certain number of sessions are being created.
   
   Maybe call it waitForSessionCreationDuration or something ?



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -265,6 +266,15 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
       builder.setCredentials(credentials.get());
     }
 
+    ValueProvider<java.time.Duration> waitForMinSessionsDuration = spannerConfig.getWaitForMinSessionsDuration();
+    java.time.Duration waitDuration = java.time.Duration.ofMinutes(5);

Review Comment:
   Please move this into a constant and add reasoning for the constant in the docs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3849438692

   Please don't force push since that:
   
   1) Resets all checks
   2) Makes it difficult to tell what has been reviewed (GitHub no longer has an easy way to see the diff from my last review)
   
   I'll retry tests if there are flakes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3872190429

   Sounds good, thanks - please comment once they are ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3849578996

   Spotless failures are unrelated, fixed by https://github.com/apache/beam/pull/37505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3849854246

   The GCP IO one seems maybe related though:
   
   ```
   SpannerChangeStreamOrderedWithinKeyGloballyIT > testOrderedWithinKey FAILED
       java.lang.AssertionError at SpannerChangeStreamOrderedWithinKeyGloballyIT.java:159
           Caused by: java.lang.AssertionError at MatcherAssert.java:18
   ```
   
   @sakthivelmanii could you please take a look? This looks mostly green at head - https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_GCP_IO_Direct.yml?query=branch%3Amaster+event%3Aschedule
   
   You can download the test results from https://github.com/apache/beam/actions/runs/21685692071?pr=37433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2743427901


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java:
##########
@@ -389,4 +393,20 @@ public SpannerConfig withUsingPlainTextChannel(ValueProvider<Boolean> plainText)
   public SpannerConfig withUsingPlainTextChannel(boolean plainText) {
     return withUsingPlainTextChannel(ValueProvider.StaticValueProvider.of(plainText));
   }
+
+  /**
+   * @param waitForMinSessionsDuration
+   * @return {@link SpannerConfig}
+   *
+   * Sets the wait time for multiplexed session to be available while creating a database client.
+   * Setting this will block the {@link com.google.cloud.spanner.DatabaseClient} creation. By default,
+   * We will be setting 5 mins as minimum wait time.
+   */
+  public SpannerConfig withWaitForMinSessionsDuration(ValueProvider<java.time.Duration> waitForMinSessionsDuration) {

Review Comment:
   done



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -265,6 +266,15 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
       builder.setCredentials(credentials.get());
     }
 
+    ValueProvider<java.time.Duration> waitForMinSessionsDuration = spannerConfig.getWaitForMinSessionsDuration();
+    java.time.Duration waitDuration = java.time.Duration.ofMinutes(5);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2743654856


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java:
##########
@@ -2109,10 +2109,9 @@ private static Dialect getDialect(SpannerConfig spannerConfig, PipelineOptions p
     // Allow passing the credential from pipeline options to the getDialect() call.
     SpannerConfig spannerConfigWithCredential =
         buildSpannerConfigWithCredential(spannerConfig, pipelineOptions);
-    try (SpannerAccessor sa = SpannerAccessor.getOrCreate(spannerConfigWithCredential)) {
-      DatabaseClient databaseClient = sa.getDatabaseClient();
-      return databaseClient.getDialect();
-    }
+    SpannerAccessor sa = SpannerAccessor.getOrCreate(spannerConfigWithCredential);
+    DatabaseClient databaseClient = sa.getDatabaseClient();
+    return databaseClient.getDialect();

Review Comment:
   Is there a reason to undo this change? It seems like it is still probably better to force the SpannerAccessor class to close



##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -614,7 +614,7 @@ class BeamModulePlugin implements Plugin<Project> {
     def google_clients_version = "2.0.0"
     def google_cloud_bigdataoss_version = "2.2.26"
     // [bomupgrader] determined by: com.google.cloud:google-cloud-spanner, consistent with: google_cloud_platform_libraries_bom
-    def google_cloud_spanner_version = "6.104.0"
+    def google_cloud_spanner_version = "6.107.0"

Review Comment:
   Do we need this version to be tracked at all now or can we remove this line?



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -265,6 +272,14 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
       builder.setCredentials(credentials.get());
     }
 
+    ValueProvider<java.time.Duration> waitForSessionCreationDuration =
+        spannerConfig.getWaitForSessionCreationDuration();
+    java.time.Duration waitDuration = Optional.ofNullable(waitForSessionCreationDuration)
+        .map(ValueProvider::get)
+        .orElse(DEFAULT_SESSION_WAIT_DURATION);
+    builder.setSessionPoolOption(
+        SessionPoolOptions.newBuilder().setWaitForMinSessionsDuration(waitDuration).build());

Review Comment:
   Is this change related to the hangs?



##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -113,6 +117,9 @@ public static SpannerAccessor getOrCreate(SpannerConfig spannerConfig) {
   static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
     SpannerOptions.Builder builder = SpannerOptions.newBuilder();
 
+    // Disable gRPC gcp extension which was causing the application thread to stall.
+    builder.disableGrpcGcpExtension();

Review Comment:
   Is the root cause known/is there a timeline for us to remove this? If so, could you please file a Beam issue tracking the fix and reference it in a TODO here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3853982173

   The same tests are failing in master branch as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3806249349

   ## Summary of Changes
   
   Hello @sakthivelmanii, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request refactors the dependency management for Google Cloud Spanner within the project's Gradle build system. Instead of explicitly declaring and pinning the Spanner version, the changes delegate this responsibility to the `google_cloud_platform_libraries_bom`. This approach streamlines versioning, promotes consistency across Google Cloud dependencies, and simplifies future updates by centralizing version control.
   
   ### Highlights
   
   * **Dependency Version Management**: The explicit version definition for `google_cloud_spanner_version` (previously `6.104.0`) has been removed from the build configuration.
   * **Spanner BOM Integration**: The `google_cloud_spanner_bom` and `google_cloud_spanner_test` dependencies are now implicitly managed by the `google_cloud_platform_libraries_bom`, ensuring version consistency with other Google Cloud Platform libraries.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   
   
   
   
   
   
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3854045243

   > The same tests are failing in master branch as well.
   
   https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_GCP_IO_Direct.yml?query=event%3Aschedule - it looks like `testTransactionBoundaries` is flaky sometimes on master, I don't see any failures involving `testOrderedWithinKey` on master though. In this PR it is red every time, so it seems like something is regressing.
   
   > I had to rebase my branch with the latest master to make spotless tests to pass
   
   Note that you can do this by merging in the master branch without losing commit history (which is the thing that GitHub's review feature relies on). (`git pull origin master`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "bharadwaj-aditya (via GitHub)" <gi...@apache.org>.
bharadwaj-aditya commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2759060619


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java:
##########
@@ -389,4 +394,22 @@ public SpannerConfig withUsingPlainTextChannel(ValueProvider<Boolean> plainText)
   public SpannerConfig withUsingPlainTextChannel(boolean plainText) {
     return withUsingPlainTextChannel(ValueProvider.StaticValueProvider.of(plainText));
   }
+
+  /**
+   * @param waitForSessionCreationDuration
+   * @return {@link SpannerConfig}
+   *     <p>Sets the wait time for multiplexed session to be available while creating a database
+   *     client. Setting this will block the {@link com.google.cloud.spanner.DatabaseClient}
+   *     creation. By default, We will be setting 5 mins as minimum wait time.

Review Comment:
   Link to the variable in these docs, just in case this changes at a later date, the docs need to be in Sync



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3872111584

   @damccorm I am seeing that setting SessionPoolOptions is causing the issue. I am trying to debug the issue. I will move this into two different PRs.
   
   
   1. Spanner upgrade. 
   2. introduce an additional to configure session creation wait time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3853909577

   I'm still seeing Spanner ChangeStreams test failures
   
   ```
   SpannerChangeStreamOrderedWithinKeyGloballyIT > testOrderedWithinKey FAILED
       java.lang.AssertionError at SpannerChangeStreamOrderedWithinKeyGloballyIT.java:159
           Caused by: java.lang.AssertionError at MatcherAssert.java:18
   
   SpannerChangeStreamOrderedByTimestampAndTransactionIdIT > testTransactionBoundaries FAILED
       java.lang.AssertionError at SpannerChangeStreamOrderedByTimestampAndTransactionIdIT.java:159
           Caused by: java.lang.AssertionError at MatcherAssert.java:18
   ```
   
   Also, as mentioned above - please avoid force pushing, it makes reviewing the PR harder


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2744448433


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -265,6 +272,14 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
       builder.setCredentials(credentials.get());
     }
 
+    ValueProvider<java.time.Duration> waitForSessionCreationDuration =
+        spannerConfig.getWaitForSessionCreationDuration();
+    java.time.Duration waitDuration = Optional.ofNullable(waitForSessionCreationDuration)
+        .map(ValueProvider::get)
+        .orElse(DEFAULT_SESSION_WAIT_DURATION);
+    builder.setSessionPoolOption(
+        SessionPoolOptions.newBuilder().setWaitForMinSessionsDuration(waitDuration).build());

Review Comment:
   No. This is related to DEADLINE EXCEEDED in dataflow workers. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "sakthivelmanii (via GitHub)" <gi...@apache.org>.
sakthivelmanii commented on code in PR #37433:
URL: https://github.com/apache/beam/pull/37433#discussion_r2744448433


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -265,6 +272,14 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
       builder.setCredentials(credentials.get());
     }
 
+    ValueProvider<java.time.Duration> waitForSessionCreationDuration =
+        spannerConfig.getWaitForSessionCreationDuration();
+    java.time.Duration waitDuration = Optional.ofNullable(waitForSessionCreationDuration)
+        .map(ValueProvider::get)
+        .orElse(DEFAULT_SESSION_WAIT_DURATION);
+    builder.setSessionPoolOption(
+        SessionPoolOptions.newBuilder().setWaitForMinSessionsDuration(waitDuration).build());

Review Comment:
   No. This is related to DEADLINE EXCEEDED in dataflow workers.  b/462499883



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3914432968

   Reminder, please take a look at this pr: @ahmedabu98 @damccorm @nielm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37433:
URL: https://github.com/apache/beam/pull/37433#issuecomment-3914561960

   Closing this PR for now since it was split up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Upgrade Spanner to the latest version [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #37433: Upgrade Spanner to the latest version
URL: https://github.com/apache/beam/pull/37433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org