You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 02:47:10 UTC

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #55: [FLINK-26546] Extract Observer Interface

wangyang0918 commented on pull request #55:
URL: https://github.com/apache/flink-kubernetes-operator/pull/55#issuecomment-1066285269


   Just a personal taste, compared to inheritance, I prefer composition. The problem of inheritance is that we do not know which methods in `BaseReconciler` and `BaseObserver` will be overridden by a subclass. Currently, it is not a major problem since we have very few methods in the interface.
   
   Note: I do not mean we have to change in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org