You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dannycranmer (via GitHub)" <gi...@apache.org> on 2023/09/06 12:18:37 UTC
[GitHub] [flink-web] dannycranmer opened a new pull request, #673: Fix the search bar on Flink website
dannycranmer opened a new pull request, #673:
URL: https://github.com/apache/flink-web/pull/673
Currently the search bar loads pages to search.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] dannycranmer merged pull request #673: Fix the search bar on Flink website
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #673:
URL: https://github.com/apache/flink-web/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] foxus commented on pull request #673: Fix the search bar on Flink website
Posted by "foxus (via GitHub)" <gi...@apache.org>.
foxus commented on PR #673:
URL: https://github.com/apache/flink-web/pull/673#issuecomment-1711933413
@MartijnVisser, I spent some time with @dannycranmer attempting to debug the behaviour of the Content filter to no avail. Whilst the filter and counter implementation is verbose, it is performant. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-web] dannycranmer commented on a diff in pull request #673: Fix the search bar on Flink website
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #673:
URL: https://github.com/apache/flink-web/pull/673#discussion_r1317235927
##########
docs/assets/search-data.js:
##########
@@ -36,15 +36,20 @@
{{- $pages := where .Site.Pages "Kind" "in" (slice "page" "section") -}}
{{- $pages = where $pages "Params.booksearchexclude" "!=" true -}}
- {{- $pages = where $pages "Content" "not in" (slice nil "") -}}
Review Comment:
@MartijnVisser I could not work out how to get this filter fixed. I tried a bunch of things, including inverting the logic from `not in` to `in`, and simplifying to `(slice nil)`/`(slice "")`. Could not get any results. I have refactored to a non-ideal loop with filter using a counter to generate the index. It works..... but it is not nice :D
Any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org