[jira] [Commented] (CLOUDSTACK-9104) VM naming convention in case vmware is used

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249517#comment-15249517 ] 

ASF GitHub Bot commented on CLOUDSTACK-9104:
--------------------------------------------

Github user priyankparihar commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1302#discussion_r60372700
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---
    @@ -2030,12 +2030,29 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) {
             return new String[] {datastoreDiskPath};
         }
     
    -    // Pair<internal CS name, vCenter display name>
    -    private Pair<String, String> composeVmNames(VirtualMachineTO vmSpec) {
    -        String vmInternalCSName = vmSpec.getName();
    -        String vmNameOnVcenter = vmSpec.getName();
    -        if (_instanceNameFlag && vmSpec.getHostName() != null) {
    -            vmNameOnVcenter = vmSpec.getHostName();
    +
    +    /**
    +     * This method gemerate VM name for Vcenter and Cloudstack( when Hypervisor is VMware).
    --- End diff --
    
    Hi  @alexandrelimassantana,
    Now, i think there is no typo.
    
    --
    Thanks for your careful observation.


> VM naming convention in case vmware is used
> -------------------------------------------
>
>                 Key: CLOUDSTACK-9104
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9104
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Priyank Parihar
>
> ISSUE
> ======
> VM naming convention in case vmware is used.
> Description
> ==========
> User with different account cannot create VMs with the same name, which was possible earlier (I am not sure in which CCP version). That time naming convention used was like this “I-<user-id>-<Display-Name>”
> Currently if vm.instancename.flag is set to true the VM name will be exactly as display name given. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)