You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jaymasiwal (via GitHub)" <gi...@apache.org> on 2026/02/15 08:34:54 UTC
[PR] fix(actionlog): restore full name display in Action Logs user column [superset]
jaymasiwal opened a new pull request, #37985:
URL: https://github.com/apache/superset/pull/37985
### SUMMARY
Restore first_name + last_name as the primary label in the Action Logs "User" column.
Since #33298, only `username` was displayed. In environments where usernames are GUIDs (e.g., Azure OAuth), this made logs difficult to read.
This change:
- Displays `first_name` + `last_name` when available
- Falls back to `username` if name fields are empty
- Shows `username` in a tooltip when full name is displayed
### SCREENSHOTS
<img width="1890" height="855" alt="image" src="https://github.com/user-attachments/assets/548dac42-118e-44d9-a5f0-79db60b35fc6" />
### TESTING INSTRUCTIONS
1. Run Superset locally.
2. Navigate to `/actionlog/list`.
3. Verify:
- Users with first_name/last_name display full name.
- Tooltip shows username on hover.
- Users without name fields fall back to username.
4. Run:
- `npm run type`
- `npm run lint`
### ADDITIONAL INFORMATION
- [x] Has associated issue: #33298
- [ ] Required feature flags
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3939123162
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #37985:
URL: https://github.com/apache/superset/pull/37985#discussion_r2811637438
##########
superset-frontend/src/pages/ActionLog/index.test.tsx:
##########
@@ -0,0 +1,68 @@
+import React from 'react';
+import '@testing-library/jest-dom';
+import { render, screen } from '@testing-library/react';
+import ActionLogList from './index';
+
+
+jest.mock('src/views/CRUD/hooks', () => ({
+ useListViewResource: () => ({
+ state: {
+ loading: false,
+ resourceCount: 1,
+ resourceCollection: [
+ {
+ action: 'test',
+ user: {
+ username: 'guid-123',
+ first_name: 'John',
+ last_name: 'Doe',
+ },
+ },
+ ],
+ bulkSelectEnabled: false,
+ },
+ fetchData: jest.fn(),
+ refreshData: jest.fn(),
+ toggleBulkSelect: jest.fn(),
+ }),
+}));
+
+jest.mock('src/components/MessageToasts/withToasts', () => ({
+ __esModule: true,
+ default: (Component: any) => Component,
+ useToasts: () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ }),
+}));
+
+jest.mock('src/features/home/SubMenu', () => ({
+ __esModule: true,
+ default: () => <div />,
+}));
+
+jest.mock('src/components/ListView', () => ({
+ __esModule: true,
+ ListView: ({ data }: any) => (
+ <div>
+ {data.map((row: any) => (
+ <div key={row.user.username}>
+ {row.user.first_name} {row.user.last_name}
+ </div>
+ ))}
+ </div>
+ ),
+ ListViewFilterOperator: {
+ RelationOneMany: 'RelationOneMany',
+ Equals: 'Equals',
+ Contains: 'Contains',
+ Between: 'Between',
+ },
+}));
+
+describe('ActionLog User column display', () => {
+ it('renders full name when first_name and last_name exist', () => {
+ render(<ActionLogList />);
+ expect(screen.getByText('John Doe')).toBeInTheDocument();
+ });
+});
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete Test Logic</b></div>
<div id="fix">
The test mocks ListView to bypass the actual column rendering, preventing verification of the user display logic in the Cell component. It only checks rendering without validating the business logic for how user names are computed and displayed.
</div>
</div>
<small><i>Code Review Run #823366</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #37985:
URL: https://github.com/apache/superset/pull/37985#discussion_r2826054037
##########
superset-frontend/src/pages/ActionLog/index.test.tsx:
##########
@@ -0,0 +1,68 @@
+import React from 'react';
+import '@testing-library/jest-dom';
+import { render, screen } from '@testing-library/react';
+import ActionLogList from './index';
+
+
+jest.mock('src/views/CRUD/hooks', () => ({
+ useListViewResource: () => ({
+ state: {
+ loading: false,
+ resourceCount: 1,
+ resourceCollection: [
+ {
+ action: 'test',
+ user: {
+ username: 'guid-123',
+ first_name: 'John',
+ last_name: 'Doe',
+ },
+ },
+ ],
+ bulkSelectEnabled: false,
+ },
+ fetchData: jest.fn(),
+ refreshData: jest.fn(),
+ toggleBulkSelect: jest.fn(),
+ }),
+}));
+
+jest.mock('src/components/MessageToasts/withToasts', () => ({
+ __esModule: true,
+ default: (Component: any) => Component,
+ useToasts: () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ }),
+}));
+
+jest.mock('src/features/home/SubMenu', () => ({
+ __esModule: true,
+ default: () => <div />,
+}));
+
+jest.mock('src/components/ListView', () => ({
+ __esModule: true,
+ ListView: ({ data }: any) => (
+ <div>
+ {data.map((row: any) => (
+ <div key={row.user.username}>
+ {row.user.first_name} {row.user.last_name}
+ </div>
+ ))}
Review Comment:
@jaymasiwal CodeAnt AI's review is legit here. The current mock-based RTL test can't verify the rendering logic of actual ActionLogList function.
Given that there's no RTL for this component prior, I'm OK with temporarily removing this RTL and provide before/after evidences for PR review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3903764291
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 632316da0ebfd692071d94129061817fdd3585d6 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6991852ef7f5f00008f738c7 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37985--superset-docs-preview.netlify.app](https://deploy-preview-37985--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37985--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3903752683
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "jaymasiwal (via GitHub)" <gi...@apache.org>.
jaymasiwal commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3907236353
Added RTL test to cover full name rendering and prevent regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3906634470
@jaymasiwal thanks for opening the PR. Can you help adding a RTL test to prevent regression in the future? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37985:
URL: https://github.com/apache/superset/pull/37985#discussion_r2811310090
##########
superset-frontend/src/pages/ActionLog/index.test.tsx:
##########
@@ -0,0 +1,68 @@
+import React from 'react';
+import '@testing-library/jest-dom';
+import { render, screen } from '@testing-library/react';
+import ActionLogList from './index';
+
+
+jest.mock('src/views/CRUD/hooks', () => ({
+ useListViewResource: () => ({
+ state: {
+ loading: false,
+ resourceCount: 1,
+ resourceCollection: [
+ {
+ action: 'test',
+ user: {
+ username: 'guid-123',
+ first_name: 'John',
+ last_name: 'Doe',
+ },
+ },
+ ],
+ bulkSelectEnabled: false,
+ },
+ fetchData: jest.fn(),
+ refreshData: jest.fn(),
+ toggleBulkSelect: jest.fn(),
+ }),
+}));
+
+jest.mock('src/components/MessageToasts/withToasts', () => ({
+ __esModule: true,
+ default: (Component: any) => Component,
+ useToasts: () => ({
+ addDangerToast: jest.fn(),
+ addSuccessToast: jest.fn(),
+ }),
+}));
+
+jest.mock('src/features/home/SubMenu', () => ({
+ __esModule: true,
+ default: () => <div />,
+}));
+
+jest.mock('src/components/ListView', () => ({
+ __esModule: true,
+ ListView: ({ data }: any) => (
+ <div>
+ {data.map((row: any) => (
+ <div key={row.user.username}>
+ {row.user.first_name} {row.user.last_name}
+ </div>
+ ))}
Review Comment:
**Suggestion:** The `ListView` mock hardcodes rendering `{row.user.first_name} {row.user.last_name}` from the raw data, bypassing the actual column/cell rendering logic in `ActionLogList`, so this test will still pass even if the "User" column regresses to showing only username or any other incorrect behavior; the mock should instead invoke the column's cell renderer so the test reflects the real implementation. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ ActionLog `/actionlog/list` user column regressions may go undetected.
- ⚠️ Jest test only validates mocked ListView output, not columns.
```
</details>
```suggestion
ListView: ({ data, columns }: any) => (
<div>
{Array.isArray(data) &&
data.map((row: any) => {
if (!Array.isArray(columns) || columns.length === 0) {
return null;
}
const userColumn =
columns.find(
(col: any) =>
col.key === 'user' ||
col.id === 'user' ||
col.accessor === 'user',
) || columns[0];
if (typeof userColumn?.Cell === 'function') {
// Mimic react-table's Cell props shape used in Superset ListView
return (
<div key={row.user?.username ?? row.id}>
{userColumn.Cell({
row: { original: row },
value: row.user,
})}
</div>
);
}
const value =
typeof userColumn?.accessor === 'function'
? userColumn.accessor(row)
: userColumn?.accessor
? row[userColumn.accessor as keyof typeof row]
: row.user?.username;
return (
<div key={row.user?.username ?? row.id}>
{value != null ? String(value) : ''}
</div>
);
})}
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open `superset-frontend/src/pages/ActionLog/index.test.tsx` and note the
`jest.mock('src/components/ListView'...)` definition at lines 44–61, where the mocked
`ListView` only accepts `{ data }` and always renders `{row.user.first_name}
{row.user.last_name}`.
2. In the same file, see the test `describe('ActionLog User column display', ...)` at
lines 63–67, which calls `render(<ActionLogList />);` and asserts `screen.getByText('John
Doe')` is in the document.
3. When this test runs, `ActionLogList` (imported from `./index` at line 4) internally
renders Superset's real `ListView`, but the import is replaced by the mock from step 1, so
the real `columns` configuration and any `Cell` renderer for the "User" column are never
used.
4. Because the mock derives `"John Doe"` directly from `row.user.first_name`/`last_name`
on the raw data, the test will keep passing even if the actual "User" column
implementation in `superset-frontend/src/pages/ActionLog/index.tsx` is later changed to
render only `username` or any other incorrect value, meaning this regression test does not
actually cover the real column rendering logic.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/pages/ActionLog/index.test.tsx
**Line:** 46:52
**Comment:**
*Logic Error: The `ListView` mock hardcodes rendering `{row.user.first_name} {row.user.last_name}` from the raw data, bypassing the actual column/cell rendering logic in `ActionLogList`, so this test will still pass even if the "User" column regresses to showing only username or any other incorrect behavior; the mock should instead invoke the column's cell renderer so the test reflects the real implementation.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37985&comment_hash=41e8ea47a18fe17b88e078b4d3007408628f45029431e9c27aa2536ef25b8306&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37985&comment_hash=41e8ea47a18fe17b88e078b4d3007408628f45029431e9c27aa2536ef25b8306&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3923432854
hi @jaymasiwal thanks for this PR! I approved CI checks to run and there are some failures, can you please investigate + resolve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3938527566
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/22254398423) for [ca86e66](https://github.com/apache/superset/commit/ca86e66)
• **Environment:** http://34.220.111.5:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3931685031
@jaymasiwal can you remove the RTL test? Apologies for asking for a RTL in the first place but current implementation is sufficient for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3925036581
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3938515214
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3907519177
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "jaymasiwal (via GitHub)" <gi...@apache.org>.
jaymasiwal commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3938459875
Removed the RTL test per feedback. Please let me know if anything else is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(actionlog): restore full name display in Action Logs user column [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37985:
URL: https://github.com/apache/superset/pull/37985#issuecomment-3938508299
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/22254398423) for [ca86e66](https://github.com/apache/superset/commit/ca86e66)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org