[GitHub] [spark] cloud-fan commented on a change in pull request #31356: [SPARK-34257][SQL] Improve performance for last_value over unbounded window frame

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31356:
URL: https://github.com/apache/spark/pull/31356#discussion_r585564095



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -237,6 +240,11 @@ trait WindowExecBase extends UnaryExecNode {
               new UnboundedWindowFunctionFrame(target, processor)
             }
 
+          case ("AGGREGATE_LAST", _, UnboundedPreceding, UnboundedFollowing, _) =>

Review comment:
       This means that we can't use one frame to evaluate `last_value` and other aggregate functions.
   
   TBH I'm not sure if it's worth extending the framework for such a small optimization.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org