[GitHub] [kafka] chia7712 commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #10123:
URL: https://github.com/apache/kafka/pull/10123#discussion_r575697037



##########
File path: checkstyle/import-control.xml
##########
@@ -144,15 +155,14 @@
     </subpackage>
 
     <subpackage name="record">
-      <allow pkg="net.jpountz" />
+      <allow pkg="org.apache.kafka.common.compression" />

Review comment:
       Could we move `CompressionType` to `org.apache.kafka.common.compression` and then make both `ZstdFactory` and SnappyFactory be package-private?

##########
File path: checkstyle/import-control.xml
##########
@@ -69,6 +69,17 @@
       <allow pkg="org.apache.kafka.common.metrics" />
     </subpackage>
 
+    <!-- Third-party compression libraries should only be references from this package -->
+    <subpackage name="compression">
+      <allow pkg="com.github.luben.zstd" />
+      <allow pkg="net.jpountz.lz4" />
+      <allow pkg="net.jpountz.xxhash" />
+      <allow pkg="org.apache.kafka.common.compression" />
+      <allow pkg="org.xerial.snappy" />
+      <!-- For testing -->

Review comment:
       This comment is a bit weird since `ZstdFactory` does reference the `org.apache.kafka.common.record.BufferSupplier`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org