You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/16 18:56:46 UTC
Review Request 32077: Rename beta-update subcommand to update.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1160
https://issues.apache.org/jira/browse/AURORA-1160
Repository: aurora
Description
-------
Rename beta-update subcommand to update.
Diffs
-----
docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
Diff: https://reviews.apache.org/r/32077/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32077: Rename beta-update subcommand to update.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/#review76608
-----------------------------------------------------------
Ship it!
Master (e11ed5b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 16, 2015, 5:57 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32077/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:57 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1160
> https://issues.apache.org/jira/browse/AURORA-1160
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Rename beta-update subcommand to update.
>
>
> Diffs
> -----
>
> docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
> docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
> docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
> examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
> src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
> src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
>
> Diff: https://reviews.apache.org/r/32077/diff/
>
>
> Testing
> -------
>
> Running end-to-end tests in an existing vagrant setup, and will repeat with a fresh one. Will report back before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32077: Rename beta-update subcommand to update.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/#review76636
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On March 16, 2015, 5:57 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32077/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:57 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1160
> https://issues.apache.org/jira/browse/AURORA-1160
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Rename beta-update subcommand to update.
>
>
> Diffs
> -----
>
> docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
> docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
> docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
> examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
> src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
> src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
>
> Diff: https://reviews.apache.org/r/32077/diff/
>
>
> Testing
> -------
>
> Running end-to-end tests in an existing vagrant setup, and will repeat with a fresh one. Will report back before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32077: Rename beta-update subcommand to update.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/
-----------------------------------------------------------
(Updated March 17, 2015, 2:24 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1160
https://issues.apache.org/jira/browse/AURORA-1160
Repository: aurora
Description
-------
Rename beta-update subcommand to update.
Diffs
-----
docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
Diff: https://reviews.apache.org/r/32077/diff/
Testing (updated)
-------
Test suite + end-to-end tests.
Thanks,
Bill Farner
Re: Review Request 32077: Rename beta-update subcommand to update.
Posted by Bill Farner <wf...@apache.org>.
> On March 16, 2015, 6:22 p.m., Zameer Manji wrote:
> > Pending e2e test results.
FYI end-to-end tests pass with this change, _in a fresh vagrant environment_. Existing envorinments will be broken, see details and proposed improvement in AURORA-1204. I will e-mail the dev@ list after committing to let folks know that they need to destroy/create.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/#review76599
-----------------------------------------------------------
On March 16, 2015, 5:57 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32077/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:57 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1160
> https://issues.apache.org/jira/browse/AURORA-1160
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Rename beta-update subcommand to update.
>
>
> Diffs
> -----
>
> docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
> docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
> docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
> examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
> src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
> src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
>
> Diff: https://reviews.apache.org/r/32077/diff/
>
>
> Testing
> -------
>
> Running end-to-end tests in an existing vagrant setup, and will repeat with a fresh one. Will report back before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32077: Rename beta-update subcommand to update.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/#review76599
-----------------------------------------------------------
Ship it!
Pending e2e test results.
- Zameer Manji
On March 16, 2015, 10:57 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32077/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 10:57 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1160
> https://issues.apache.org/jira/browse/AURORA-1160
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Rename beta-update subcommand to update.
>
>
> Diffs
> -----
>
> docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
> docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
> docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
> examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
> src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
> src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
> src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
>
> Diff: https://reviews.apache.org/r/32077/diff/
>
>
> Testing
> -------
>
> Running end-to-end tests in an existing vagrant setup, and will repeat with a fresh one. Will report back before committing.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32077: Rename beta-update subcommand to update.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/
-----------------------------------------------------------
(Updated March 16, 2015, 5:57 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1160
https://issues.apache.org/jira/browse/AURORA-1160
Repository: aurora
Description
-------
Rename beta-update subcommand to update.
Diffs
-----
docs/client-commands.md f0769b5db58971c345090ee584fa5fc11e2a057a
docs/configuration-reference.md af0386202844a0ab706c691068d587cefc75becf
docs/hooks.md 23cc207700ca1cca8ae5827345a5812ab2af9d61
examples/vagrant/upstart/aurora-scheduler.conf f85127d9d565c3c91eca914f73f28005d763234c
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c60d1e78e0f5c474ff0dcf6393e0c305d865bded
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java b1d633602f3fb021a026a087b91d41580798eeaf
src/main/python/apache/aurora/client/cli/update.py cced1080655a0d6648883c16edf07f7ad75a2ca1
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 89b9ce0a4150a88e8d9099e711659b591dcdd947
src/test/python/apache/aurora/client/cli/test_supdate.py a237da92229e21253aaca488a89af2979d94ce48
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f255f2d0a390359da4f442505fc7b8b492dc06bb
Diff: https://reviews.apache.org/r/32077/diff/
Testing (updated)
-------
Running end-to-end tests in an existing vagrant setup, and will repeat with a fresh one. Will report back before committing.
Thanks,
Bill Farner