You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2013/04/02 18:55:15 UTC
[jira] [Commented] (BOOKKEEPER-596) Ledgers are gc'ed by mistake in
MSLedgerManagerFactory.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619991#comment-13619991 ]
Ivan Kelly commented on BOOKKEEPER-596:
---------------------------------------
regarding the change to the ScanAndCompareGC, it feels like this addition is a bit of a hack. Really, a ledger range iterator should return a range set like
[(NOLIMIT, 10), (11, 20), (21, 30), (31, NOLIMIT)]
This would remove the necessity for special handling, and it would also cover the case where ledgers exist on the bookie which are lower than the lower bound of the ledger ranges. This patch only handles those which are above the upper bound.
Further to this, I think NOLIMIT should be replaced with MIN_LEDGER_ID and MAX_LEDGER_ID to make things clearer.
> Ledgers are gc'ed by mistake in MSLedgerManagerFactory.
> -------------------------------------------------------
>
> Key: BOOKKEEPER-596
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-596
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 4.2.0, 4.2.1
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-596.patch, BOOKKEEPER-596.patch
>
>
> details: https://issues.apache.org/jira/browse/BOOKKEEPER-590?focusedCommentId=13616397&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13616397
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira