You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/10/05 14:14:36 UTC
[PR] CAMEL-19950: camel-report-maven-plugin - Get rid of grape [camel]
essobedo opened a new pull request, #11655:
URL: https://github.com/apache/camel/pull/11655
Fixes https://issues.apache.org/jira/browse/CAMEL-19950
## Motivation
The maven plugin `camel-report-maven-plugin` still uses Groovy Grape and we would like to get rid of it.
## Modifications:
* Change the dependency `camel-catalog-maven-grape` for `camel-catalog-maven`
* Add explicitly the dependencies that cause a warning when not scoped with `provided`
* Adapt the code of `MavenDownloaderImpl` to accept predefined `RepositorySystem`, `RepositorySystemSession`, and `Settings` to ensure that internal maven classes are not used during initialization
* Remove the artifact `camel-catalog-maven-grape` and its references as it is no longer used
## Result:
```
mvn camel-report:validate -pl tests/camel-itest
[INFO] Scanning for projects...
[INFO]
[INFO] --------------------< org.apache.camel:camel-itest >--------------------
[INFO] Building Camel :: Integration Tests 4.1.0-SNAPSHOT
[INFO] from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- camel-report:4.1.0-SNAPSHOT:validate (default-cli) @ camel-itest ---
[INFO] Detected Camel version used in project: 4.1.0-SNAPSHOT
[INFO] Validating using Camel version: 4.1.0-SNAPSHOT
[INFO] Endpoint validation success: (433 = passed, 0 = invalid, 6 = incapable, 2 = unknown components, 0 = deprecated options)
[WARNING] Simple validation error at: org.apache.camel.itest.greeter.JettyRecipientListCxfIssueTest(JettyRecipientListCxfIssueTest.xml:76)
Illegal syntax: resource:greetMe-reply1.xml
[WARNING] Simple validation error at: org.apache.camel.itest.greeter.JettyRecipientListCxfIssueTest(JettyRecipientListCxfIssueTest.xml:89)
Illegal syntax: resource:greetMe-reply2.xml
[WARNING] Simple validation error: (17 = passed, 2 = invalid)
[WARNING] Endpoint pair (seda/direct) validation error at: spring-config.server-applicationContext(server-applicationContext.xml:61)
direct:serverInbound
serverInbound Sending to non existing direct queue name
[WARNING] Endpoint pair (seda/direct) validation error at: spring-config.server-WsAddressingContext(server-WsAddressingContext.xml:62)
direct:serverInbound
serverInbound Sending to non existing direct queue name
[WARNING] Endpoint pair (seda/direct) validation error: (3 = pairs, 2 = non-pairs)
[INFO] Duplicate route id validation success: (64 = ids)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.641 s
[INFO] Finished at: 2023-10-05T16:14:05+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.camel:camel-report-maven-plugin:4.1.0-SNAPSHOT:validate (default-cli) on project camel-itest: Endpoint validation success: (433 = passed, 0 = invalid, 6 = incapable, 2 = unknown components, 0 = deprecated options)
[ERROR] Simple validation error: (17 = passed, 2 = invalid)
[ERROR] Duplicate route id validation success: (64 = ids)
[ERROR] Endpoint pair (seda/direct) validation error: (3 = pairs, 2 = non-pairs)
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-19950: camel-report-maven-plugin - Get rid of grape [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #11655:
URL: https://github.com/apache/camel/pull/11655#discussion_r1347512430
##########
docs/user-manual/modules/ROOT/pages/camel-report-maven-plugin.adoc:
##########
@@ -172,7 +172,7 @@ $mvn org.apache.camel:camel-report-maven-plugin:3.0.0:validate -Dcamel.includeTe
----
-== camel:route-coverage
+== camel-camel:route-coverage
Review Comment:
camel-report
##########
catalog/camel-report-maven-plugin/src/main/docs/camel-report-maven-plugin.adoc:
##########
@@ -172,7 +172,7 @@ $mvn org.apache.camel:camel-report-maven-plugin:3.0.0:validate -Dcamel.includeTe
----
-== camel:route-coverage
+== camel-camel:route-coverage
Review Comment:
camel-report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-19950: camel-report-maven-plugin - Get rid of grape [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11655:
URL: https://github.com/apache/camel/pull/11655#issuecomment-1748991670
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-19950: camel-report-maven-plugin - Get rid of grape [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #11655:
URL: https://github.com/apache/camel/pull/11655#discussion_r1347522299
##########
catalog/camel-report-maven-plugin/src/main/docs/camel-report-maven-plugin.adoc:
##########
@@ -172,7 +172,7 @@ $mvn org.apache.camel:camel-report-maven-plugin:3.0.0:validate -Dcamel.includeTe
----
-== camel:route-coverage
+== camel-camel:route-coverage
Review Comment:
OOPS, LOL, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-19950: camel-report-maven-plugin - Get rid of grape [camel]
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #11655:
URL: https://github.com/apache/camel/pull/11655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org