You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/14 01:39:36 UTC
[GitHub] 10110346 closed pull request #23295: [MINOR][SQL]Change
`ThreadLocal.withInitial` to Scala lambda syntax
10110346 closed pull request #23295: [MINOR][SQL]Change `ThreadLocal.withInitial` to Scala lambda syntax
URL: https://github.com/apache/spark/pull/23295
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
index fbda0d87a175f..30c46975877f2 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
@@ -19,7 +19,6 @@ package org.apache.spark.sql.execution
import java.io.Writer
import java.util.Locale
-import java.util.function.Supplier
import scala.collection.mutable
import scala.util.control.NonFatal
@@ -557,9 +556,7 @@ object WholeStageCodegenId {
// is created, e.g. for special fallback handling when an existing WholeStageCodegenExec
// failed to generate/compile code.
- private val codegenStageCounter = ThreadLocal.withInitial(new Supplier[Integer] {
- override def get() = 1 // TODO: change to Scala lambda syntax when upgraded to Scala 2.12+
- })
+ private val codegenStageCounter = ThreadLocal.withInitial[Int](() => 1)
def resetPerQuery(): Unit = codegenStageCounter.set(1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org