You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:14:29 UTC
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request
#744: MINIFICPP-1171 - Fix "%ll" format strings in log lines
szaszm commented on a change in pull request #744: MINIFICPP-1171 - Fix "%ll" format strings in log lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/744#discussion_r387612083
##########
File path: extensions/mqtt/processors/AbstractMQTTProcessor.cpp
##########
@@ -92,22 +92,22 @@ void AbstractMQTTProcessor::onSchedule(const std::shared_ptr<core::ProcessContex
core::TimeUnit unit;
if (core::Property::StringToTime(value, valInt, unit) && core::Property::ConvertTimeUnitToMS(valInt, unit, valInt)) {
keepAliveInterval_ = valInt/1000;
- logger_->log_debug("AbstractMQTTProcessor: KeepLiveInterval [%ll]", keepAliveInterval_);
+ logger_->log_debug("AbstractMQTTProcessor: KeepLiveInterval [%lld]", keepAliveInterval_);
Review comment:
Use `PRId64` from `<cinttypes>` for `int64_t`. `lld` is meant to be used for `long long int`, which is not guaranteed to be the same as `int64_t`. It is not the same on my platform.
The above applies to all 3 changes in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services