You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/10/13 23:22:40 UTC
Review Request 26660: Admin View: IE10 issues when sorting a new user,
and toggling visibility of View
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26660/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-7766
https://issues.apache.org/jira/browse/AMBARI-7766
Repository: ambari
Description
-------
In IE 10, the following does not work.
Have multiple users already created. When adding a user, the operation completes but the user does not appear in alphabetical order.
Create a View. Then edit the view by toggling its visibility setting, and clicking "Save". The operation is not actually saved.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js e949527
ambari-admin/src/main/resources/ui/admin-web/test/unit/common/app_test.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js c5a7d67
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 23afcb6
Diff: https://reviews.apache.org/r/26660/diff/
Testing
-------
Ran unit and functional tests. Plus IE 10 test (see video attachment in Jira).
$ npm run test-single-run
> adminconsole@0.0.0 test-single-run /Users/afernandez/Documents/git/ambari-vagrant/centos6.4/ambari/ambari-admin/src/main/resources/ui/admin-web
> node node_modules/karma/bin/karma start test/karma.conf.js --single-run
INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket _3Yro96OhoOEGaqJYErO with id 45621533
PhantomJS 1.9.7 (Mac OS X): Executed 8 of 8 SUCCESS (0.01 secs / 0.071 secs)
$ npm run update-webdriver
$ npm start
$ npm run protractor
Finished in 1.432 seconds
1 test, 0 assertions, 0 failures
Thanks,
Alejandro Fernandez
Re: Review Request 26660: Admin View: IE10 issues when sorting a new
user, and toggling visibility of View
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26660/#review56967
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Oct. 13, 2014, 9:22 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26660/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 9:22 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-7766
> https://issues.apache.org/jira/browse/AMBARI-7766
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In IE 10, the following does not work.
> Have multiple users already created. When adding a user, the operation completes but the user does not appear in alphabetical order.
> Create a View. Then edit the view by toggling its visibility setting, and clicking "Save". The operation is not actually saved.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js e949527
> ambari-admin/src/main/resources/ui/admin-web/test/unit/common/app_test.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js c5a7d67
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 23afcb6
>
> Diff: https://reviews.apache.org/r/26660/diff/
>
>
> Testing
> -------
>
> Ran unit and functional tests. Plus IE 10 test (see video attachment in Jira).
>
> $ npm run test-single-run
>
> > adminconsole@0.0.0 test-single-run /Users/afernandez/Documents/git/ambari-vagrant/centos6.4/ambari/ambari-admin/src/main/resources/ui/admin-web
> > node node_modules/karma/bin/karma start test/karma.conf.js --single-run
>
> INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
> INFO [launcher]: Starting browser PhantomJS
> INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket _3Yro96OhoOEGaqJYErO with id 45621533
> PhantomJS 1.9.7 (Mac OS X): Executed 8 of 8 SUCCESS (0.01 secs / 0.071 secs)
>
>
> $ npm run update-webdriver
> $ npm start
> $ npm run protractor
> Finished in 1.432 seconds
> 1 test, 0 assertions, 0 failures
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 26660: Admin View: IE10 issues when sorting a new
user, and toggling visibility of View
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26660/#review56986
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Oct. 16, 2014, 7:37 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26660/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 7:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-7766
> https://issues.apache.org/jira/browse/AMBARI-7766
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In IE 10, the following does not work.
> Have multiple users already created. When adding a user, the operation completes but the user does not appear in alphabetical order.
> Create a View. Then edit the view by toggling its visibility setting, and clicking "Save". The operation is not actually saved.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js e949527
> ambari-admin/src/main/resources/ui/admin-web/test/unit/common/app_test.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js c5a7d67
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 23afcb6
>
> Diff: https://reviews.apache.org/r/26660/diff/
>
>
> Testing
> -------
>
> Ran unit and functional tests. Plus IE 10 test (see video attachment in Jira).
>
> $ npm run test-single-run
>
> > adminconsole@0.0.0 test-single-run /Users/afernandez/Documents/git/ambari-vagrant/centos6.4/ambari/ambari-admin/src/main/resources/ui/admin-web
> > node node_modules/karma/bin/karma start test/karma.conf.js --single-run
>
> INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
> INFO [launcher]: Starting browser PhantomJS
> INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket _3Yro96OhoOEGaqJYErO with id 45621533
> PhantomJS 1.9.7 (Mac OS X): Executed 8 of 8 SUCCESS (0.01 secs / 0.071 secs)
>
>
> $ npm run update-webdriver
> $ npm start
> $ npm run protractor
> Finished in 1.432 seconds
> 1 test, 0 assertions, 0 failures
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 26660: Admin View: IE10 issues when sorting a new
user, and toggling visibility of View
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26660/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 7:37 p.m.)
Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-7766
https://issues.apache.org/jira/browse/AMBARI-7766
Repository: ambari
Description
-------
In IE 10, the following does not work.
Have multiple users already created. When adding a user, the operation completes but the user does not appear in alphabetical order.
Create a View. Then edit the view by toggling its visibility setting, and clicking "Save". The operation is not actually saved.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js e949527
ambari-admin/src/main/resources/ui/admin-web/test/unit/common/app_test.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js c5a7d67
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 23afcb6
Diff: https://reviews.apache.org/r/26660/diff/
Testing
-------
Ran unit and functional tests. Plus IE 10 test (see video attachment in Jira).
$ npm run test-single-run
> adminconsole@0.0.0 test-single-run /Users/afernandez/Documents/git/ambari-vagrant/centos6.4/ambari/ambari-admin/src/main/resources/ui/admin-web
> node node_modules/karma/bin/karma start test/karma.conf.js --single-run
INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket _3Yro96OhoOEGaqJYErO with id 45621533
PhantomJS 1.9.7 (Mac OS X): Executed 8 of 8 SUCCESS (0.01 secs / 0.071 secs)
$ npm run update-webdriver
$ npm start
$ npm run protractor
Finished in 1.432 seconds
1 test, 0 assertions, 0 failures
Thanks,
Alejandro Fernandez
Re: Review Request 26660: Admin View: IE10 issues when sorting a new
user, and toggling visibility of View
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26660/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 7:37 p.m.)
Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-7766
https://issues.apache.org/jira/browse/AMBARI-7766
Repository: ambari
Description
-------
In IE 10, the following does not work.
Have multiple users already created. When adding a user, the operation completes but the user does not appear in alphabetical order.
Create a View. Then edit the view by toggling its visibility setting, and clicking "Save". The operation is not actually saved.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js e949527
ambari-admin/src/main/resources/ui/admin-web/test/unit/common/app_test.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js c5a7d67
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/mainCtrl_test.js 23afcb6
Diff: https://reviews.apache.org/r/26660/diff/
Testing
-------
Ran unit and functional tests. Plus IE 10 test (see video attachment in Jira).
$ npm run test-single-run
> adminconsole@0.0.0 test-single-run /Users/afernandez/Documents/git/ambari-vagrant/centos6.4/ambari/ambari-admin/src/main/resources/ui/admin-web
> node node_modules/karma/bin/karma start test/karma.conf.js --single-run
INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket _3Yro96OhoOEGaqJYErO with id 45621533
PhantomJS 1.9.7 (Mac OS X): Executed 8 of 8 SUCCESS (0.01 secs / 0.071 secs)
$ npm run update-webdriver
$ npm start
$ npm run protractor
Finished in 1.432 seconds
1 test, 0 assertions, 0 failures
Thanks,
Alejandro Fernandez