You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by "Saifulhuq01 (via GitHub)" <gi...@apache.org> on 2026/02/02 04:44:57 UTC

Re: [PR] FINERACT-2459: Refactor SmsReadPlatformServiceImpl to use Prepared Statements [fineract]

Saifulhuq01 commented on PR #5407:
URL: https://github.com/apache/fineract/pull/5407#issuecomment-3832885676

   > @Saifulhuq01 the PR and the commit doesn't follow the title conventions use "[FINERACT-854](https://issues.apache.org/jira/browse/FINERACT-854): Use prepared statements instead of string concatenated SQL everywhere" squash and commit your changes because only 1 commit per PR is required. Maybe you should open a new Jira ticket on Apache Fineract jira for only one use case, because the title is "everywhere" and make sure the changes include a test.
   
   Hi @IOhacker, just a friendly bump on this. I have addressed the previous feedback (Squashed commits + JIRA ticket). Let me know if further changes are needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org