You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/23 11:22:47 UTC
[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #4502: [ISSUE #4501] fix Namesrv auto discovery not work
lizhanhui commented on code in PR #4502:
URL: https://github.com/apache/rocketmq/pull/4502#discussion_r904902016
##########
broker/src/main/java/org/apache/rocketmq/broker/out/BrokerOuterAPI.java:
##########
@@ -86,7 +86,7 @@ public void shutdown() {
public String fetchNameServerAddr() {
try {
String addrs = this.topAddressing.fetchNSAddr();
- if (addrs != null) {
Review Comment:
UtillAll.isBlank already has nullable checking
https://github.com/apache/rocketmq/blob/da01deb961807c68b102aeccb1f06d9721ca700e/common/src/main/java/org/apache/rocketmq/common/UtilAll.java#L415
##########
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##########
@@ -227,7 +227,7 @@ public RemotingClient getRemotingClient() {
public String fetchNameServerAddr() {
try {
String addrs = this.topAddressing.fetchNSAddr();
- if (addrs != null) {
Review Comment:
UtillAll.isBlank already has nullable checking
https://github.com/apache/rocketmq/blob/da01deb961807c68b102aeccb1f06d9721ca700e/common/src/main/java/org/apache/rocketmq/common/UtilAll.java#L415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org