You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by tuna <ng...@gmail.com> on 2013/07/25 11:05:39 UTC
Review Request 12941: [GSoC] refactor gre controller
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/
-----------------------------------------------------------
Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
I made an update to refactor gre controller:
+ remove ovs_devices table, because we'll have an ODL plugin separately.
+ move command/answer to new package: com.cloud.agent.api
+ add Connectivity service checking
+ add new NetworkProvider: Ovs
+ add L3 services to Ovs Capabilities
+ add L3 services prototype code.
Next step:
+ L3 services implement with VirtualRouter
+ ODL plugin
Diffs
-----
api/src/com/cloud/network/Network.java a06208b
client/tomcatconf/applicationContext.xml.in 60f1e30
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2
plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324
plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb
plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b
plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e
plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e
plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48
plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6
plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8
setup/db/create-schema.sql 143023a
Diff: https://reviews.apache.org/r/12941/diff/
Testing
-------
Thanks,
tuna
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by Nguyen Anh Tu <ng...@gmail.com>.
Hi Hugo,
Do you want to keep sdn.ovs.controller param in configuration? I have
already replaced it by checking whether physical-network-isolation-type is
GRE or not. But I just see two threads using this param and I don't know
what they run for. It's placed at configure() method of OvsTunnelManager.
_isEnabled =
Boolean.parseBoolean(_configDao.getValue(Config.OvsTunnelNetwork.key()));
//sdn.ovs.controller=true
if (_isEnabled) {
_executorPool = Executors.newScheduledThreadPool(10, new
NamedThreadFactory("OVS"));
_cleanupExecutor = Executors.newScheduledThreadPool(1, new
NamedThreadFactory("OVS-Cleanup"));
}
Cheers,
2013/7/29 Nguyen Anh Tu <ng...@gmail.com>
> Hi,
>
> Following Hugo's review, I already changed and created an updated patch.
> Now I'm re-deploying system for final-testing before submitting the update
> patch. But getting an error on creating systemvm. Let me fix them first,
> make final-test and then submit the updated patch.
>
> Cheers,
>
>
> 2013/7/26 Nguyen Anh Tu <ng...@gmail.com>
>
>> Hi Hugo,
>>
>> I saw your review. But I have to concentrate to finish my report today.
>> Will comeback to review tomorrow :-)
>>
>>
>> 2013/7/25 Jenkins Cloudstack.org <hu...@apache.org>
>>
>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/12941/
>>>
>>> Review 12941 failed the build test : FAILURE
>>> The url of build cloudstack-master-with-patch #37 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/
>>>
>>>
>>> - Jenkins Cloudstack.org
>>>
>>> On July 25th, 2013, 9:05 a.m. UTC, tuna wrote:
>>> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>>> By tuna.
>>>
>>> *Updated July 25, 2013, 9:05 a.m.*
>>> *Repository: * cloudstack-git
>>> Description
>>>
>>> I made an update to refactor gre controller:
>>>
>>> + remove ovs_devices table, because we'll have an ODL plugin separately.
>>> + move command/answer to new package: com.cloud.agent.api
>>> + add Connectivity service checking
>>> + add new NetworkProvider: Ovs
>>> + add L3 services to Ovs Capabilities
>>> + add L3 services prototype code.
>>>
>>> Next step:
>>> + L3 services implement with VirtualRouter
>>> + ODL plugin
>>>
>>> Diffs
>>>
>>> - api/src/com/cloud/network/Network.java (a06208b)
>>> - client/tomcatconf/applicationContext.xml.in (60f1e30)
>>> - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>>> (30b0521)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java
>>> (PRE-CREATION)
>>> - plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java
>>> (c0901b2)
>>> - plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java
>>> (1abc324)
>>> - plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java
>>> (87eedfb)
>>> - plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java
>>> (2adb33a)
>>> - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
>>> (0ea6b52)
>>> - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java
>>> (b55fe6b)
>>> - plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
>>> (bbdf110)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java
>>> (b533312)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java
>>> (20603e0)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java
>>> (5f0f8c1)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java
>>> (e2cd2d8)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java
>>> (fc2eb8a)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java
>>> (1ececa0)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java
>>> (2a6d5d7)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java
>>> (8be5586)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java
>>> (4594d99)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java
>>> (1ee6606)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java
>>> (c27daf0)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java
>>> (ba16839)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java
>>> (17121a0)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java
>>> (29cce15)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
>>> (b1ecaac)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java
>>> (b85331e)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java
>>> (794e45e)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java
>>> (11a4d48)
>>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java
>>> (cab63f6)
>>> - plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java
>>> (a94e4f8)
>>> - setup/db/create-schema.sql (143023a)
>>>
>>> View Diff <https://reviews.apache.org/r/12941/diff/>
>>>
>>
>>
>>
>> --
>>
>> N.g.U.y.e.N.A.n.H.t.U
>>
>
>
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>
--
N.g.U.y.e.N.A.n.H.t.U
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by Nguyen Anh Tu <ng...@gmail.com>.
Hi,
Following Hugo's review, I already changed and created an updated patch.
Now I'm re-deploying system for final-testing before submitting the update
patch. But getting an error on creating systemvm. Let me fix them first,
make final-test and then submit the updated patch.
Cheers,
2013/7/26 Nguyen Anh Tu <ng...@gmail.com>
> Hi Hugo,
>
> I saw your review. But I have to concentrate to finish my report today.
> Will comeback to review tomorrow :-)
>
>
> 2013/7/25 Jenkins Cloudstack.org <hu...@apache.org>
>
> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/12941/
>>
>> Review 12941 failed the build test : FAILURE
>> The url of build cloudstack-master-with-patch #37 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/
>>
>>
>> - Jenkins Cloudstack.org
>>
>> On July 25th, 2013, 9:05 a.m. UTC, tuna wrote:
>> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>> By tuna.
>>
>> *Updated July 25, 2013, 9:05 a.m.*
>> *Repository: * cloudstack-git
>> Description
>>
>> I made an update to refactor gre controller:
>>
>> + remove ovs_devices table, because we'll have an ODL plugin separately.
>> + move command/answer to new package: com.cloud.agent.api
>> + add Connectivity service checking
>> + add new NetworkProvider: Ovs
>> + add L3 services to Ovs Capabilities
>> + add L3 services prototype code.
>>
>> Next step:
>> + L3 services implement with VirtualRouter
>> + ODL plugin
>>
>> Diffs
>>
>> - api/src/com/cloud/network/Network.java (a06208b)
>> - client/tomcatconf/applicationContext.xml.in (60f1e30)
>> - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>> (30b0521)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java
>> (PRE-CREATION)
>> - plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java
>> (c0901b2)
>> - plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java
>> (1abc324)
>> - plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java
>> (87eedfb)
>> - plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java
>> (2adb33a)
>> - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
>> (0ea6b52)
>> - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java
>> (b55fe6b)
>> - plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
>> (bbdf110)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java
>> (b533312)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java
>> (20603e0)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java
>> (5f0f8c1)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java
>> (e2cd2d8)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java
>> (fc2eb8a)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java
>> (1ececa0)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java
>> (2a6d5d7)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java
>> (8be5586)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java
>> (4594d99)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java
>> (1ee6606)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java
>> (c27daf0)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java
>> (ba16839)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java
>> (17121a0)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java
>> (29cce15)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
>> (b1ecaac)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java
>> (b85331e)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java
>> (794e45e)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java
>> (11a4d48)
>> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java
>> (cab63f6)
>> - plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java
>> (a94e4f8)
>> - setup/db/create-schema.sql (143023a)
>>
>> View Diff <https://reviews.apache.org/r/12941/diff/>
>>
>
>
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>
--
N.g.U.y.e.N.A.n.H.t.U
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by Nguyen Anh Tu <ng...@gmail.com>.
Hi Hugo,
I saw your review. But I have to concentrate to finish my report today.
Will comeback to review tomorrow :-)
2013/7/25 Jenkins Cloudstack.org <hu...@apache.org>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12941/
>
> Review 12941 failed the build test : FAILURE
> The url of build cloudstack-master-with-patch #37 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/
>
>
> - Jenkins Cloudstack.org
>
> On July 25th, 2013, 9:05 a.m. UTC, tuna wrote:
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> By tuna.
>
> *Updated July 25, 2013, 9:05 a.m.*
> *Repository: * cloudstack-git
> Description
>
> I made an update to refactor gre controller:
>
> + remove ovs_devices table, because we'll have an ODL plugin separately.
> + move command/answer to new package: com.cloud.agent.api
> + add Connectivity service checking
> + add new NetworkProvider: Ovs
> + add L3 services to Ovs Capabilities
> + add L3 services prototype code.
>
> Next step:
> + L3 services implement with VirtualRouter
> + ODL plugin
>
> Diffs
>
> - api/src/com/cloud/network/Network.java (a06208b)
> - client/tomcatconf/applicationContext.xml.in (60f1e30)
> - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> (30b0521)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java
> (PRE-CREATION)
> - plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java
> (c0901b2)
> - plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java
> (1abc324)
> - plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java
> (87eedfb)
> - plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java
> (2adb33a)
> - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
> (0ea6b52)
> - plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java
> (b55fe6b)
> - plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
> (bbdf110)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java
> (b533312)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java
> (20603e0)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java
> (5f0f8c1)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java
> (e2cd2d8)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java
> (fc2eb8a)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java
> (1ececa0)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java
> (2a6d5d7)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java
> (8be5586)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java
> (4594d99)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java
> (1ee6606)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java
> (c27daf0)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java
> (ba16839)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java
> (17121a0)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java
> (29cce15)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java
> (b1ecaac)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java
> (b85331e)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java
> (794e45e)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java
> (11a4d48)
> - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java
> (cab63f6)
> - plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java
> (a94e4f8)
> - setup/db/create-schema.sql (143023a)
>
> View Diff <https://reviews.apache.org/r/12941/diff/>
>
--
N.g.U.y.e.N.A.n.H.t.U
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/#review23833
-----------------------------------------------------------
Review 12941 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #37 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/
- Jenkins Cloudstack.org
On July 25, 2013, 9:05 a.m., tuna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12941/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 9:05 a.m.)
>
>
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I made an update to refactor gre controller:
>
> + remove ovs_devices table, because we'll have an ODL plugin separately.
> + move command/answer to new package: com.cloud.agent.api
> + add Connectivity service checking
> + add new NetworkProvider: Ovs
> + add L3 services to Ovs Capabilities
> + add L3 services prototype code.
>
> Next step:
> + L3 services implement with VirtualRouter
> + ODL plugin
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java a06208b
> client/tomcatconf/applicationContext.xml.in 60f1e30
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2
> plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324
> plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb
> plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b
> plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e
> plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e
> plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48
> plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6
> plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8
> setup/db/create-schema.sql 143023a
>
> Diff: https://reviews.apache.org/r/12941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> tuna
>
>
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/#review23827
-----------------------------------------------------------
Heya,
There is some feedback from reading the diffs. In general the patch looks good, i'll try and implement a setup based on this so i can test it. I'm assuming that with this patch we can get the L2 part of the GRE based SDN working?
Can you explain what testing you did to prove that this code works? What did your setup look like and what tests did you execute?
Cheers,
Hugo
api/src/com/cloud/network/Network.java
<https://reviews.apache.org/r/12941/#comment47666>
Please double check the code style. Not tabs, 4 spaces indent for example. The full style guide is available on confluence.
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/12941/#comment47667>
Please check the style guide :-) No wild card imports.
http://cloudstack.apache.org/develop/coding-conventions.html
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java
<https://reviews.apache.org/r/12941/#comment47668>
You need the place holders, but to keep that patch clean it's often better to do that in an other patch.
One patch with the functionality that is ready and can be used. Another one that will enabled place holders for future usage.
Now we can't apply this patch to master because you advertise functionality that is not really implemented.
plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java
<https://reviews.apache.org/r/12941/#comment47670>
This should be gone, determining if the GRE tunnel manager should be used must happen based on the settings of the physical network isolation type "GRE".
setup/db/create-schema.sql
<https://reviews.apache.org/r/12941/#comment47671>
Please don't make changes to this file. Changes should be processed by the upgrade scripts.
See http://markmail.org/message/uo7yq2qws2amjkfu
- Hugo Trippaers
On July 25, 2013, 9:05 a.m., tuna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12941/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 9:05 a.m.)
>
>
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I made an update to refactor gre controller:
>
> + remove ovs_devices table, because we'll have an ODL plugin separately.
> + move command/answer to new package: com.cloud.agent.api
> + add Connectivity service checking
> + add new NetworkProvider: Ovs
> + add L3 services to Ovs Capabilities
> + add L3 services prototype code.
>
> Next step:
> + L3 services implement with VirtualRouter
> + ODL plugin
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java a06208b
> client/tomcatconf/applicationContext.xml.in 60f1e30
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2
> plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324
> plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb
> plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b
> plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e
> plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e
> plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48
> plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6
> plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8
> setup/db/create-schema.sql 143023a
>
> Diff: https://reviews.apache.org/r/12941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> tuna
>
>
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
> On Aug. 12, 2013, 11:30 a.m., Hugo Trippaers wrote:
> > Ship It!
Targeted to the sdnextensions branch.
Commit id : 0d6125f36449b1fcbbc5d296496c4a01f2208fc4
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/#review24990
-----------------------------------------------------------
On Aug. 1, 2013, 1:41 a.m., tuna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12941/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 1:41 a.m.)
>
>
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I made an update to refactor gre controller:
>
> + remove ovs_devices table, because we'll have an ODL plugin separately.
> + move command/answer to new package: com.cloud.agent.api
> + add Connectivity service checking
> + add new NetworkProvider: Ovs
> + add L3 services to Ovs Capabilities
> + add L3 services prototype code.
>
> Next step:
> + L3 services implement with VirtualRouter
> + ODL plugin
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java a06208b
> api/src/com/cloud/network/OvsProvider.java PRE-CREATION
> api/src/com/cloud/network/element/VirtualRouterElementService.java ea971b8
> api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb
> api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java PRE-CREATION
> client/tomcatconf/applicationContext.xml.in 60f1e30
> client/tomcatconf/commands.properties.in 6ec4d92
> engine/schema/src/com/cloud/network/dao/OvsProviderDao.java PRE-CREATION
> engine/schema/src/com/cloud/network/dao/OvsProviderDaoImpl.java PRE-CREATION
> engine/schema/src/com/cloud/network/element/OvsProviderVO.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b
> plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> scripts/vm/hypervisor/xenserver/ovstunnel a4760b2
> server/src/com/cloud/api/ApiResponseHelper.java 090d9c2
> server/src/com/cloud/network/NetworkServiceImpl.java d4f9030
> server/src/com/cloud/network/element/VirtualRouterElement.java 1916678
> server/src/com/cloud/server/ManagementServerImpl.java 36b3879
> setup/db/create-schema.sql 143023a
> setup/db/db/schema-410to420.sql b48ae6a
> tools/apidoc/gen_toc.py 33a7e75
> ui/scripts/zoneWizard.js e2ad910
>
> Diff: https://reviews.apache.org/r/12941/diff/
>
>
> Testing
> -------
>
> Test done with following cases:
>
> + choose GRE method, VLAN range when deploy advanced zone
> + create new Network Offering and choose Ovs for VirtualNetworking service, VirtualRouter for other services.
> + create a new Guest network using this new NetworkOffering
> + deploy VMs on this Guest network
> + stop, restart, destroy VMs
> + deploy, stop, restart, destroy VMs on two hosts.
>
>
> Thanks,
>
> tuna
>
>
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/#review24990
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On Aug. 1, 2013, 1:41 a.m., tuna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12941/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 1:41 a.m.)
>
>
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> I made an update to refactor gre controller:
>
> + remove ovs_devices table, because we'll have an ODL plugin separately.
> + move command/answer to new package: com.cloud.agent.api
> + add Connectivity service checking
> + add new NetworkProvider: Ovs
> + add L3 services to Ovs Capabilities
> + add L3 services prototype code.
>
> Next step:
> + L3 services implement with VirtualRouter
> + ODL plugin
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/Network.java a06208b
> api/src/com/cloud/network/OvsProvider.java PRE-CREATION
> api/src/com/cloud/network/element/VirtualRouterElementService.java ea971b8
> api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb
> api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java PRE-CREATION
> client/tomcatconf/applicationContext.xml.in 60f1e30
> client/tomcatconf/commands.properties.in 6ec4d92
> engine/schema/src/com/cloud/network/dao/OvsProviderDao.java PRE-CREATION
> engine/schema/src/com/cloud/network/dao/OvsProviderDaoImpl.java PRE-CREATION
> engine/schema/src/com/cloud/network/element/OvsProviderVO.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52
> plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b
> plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110
> plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
> scripts/vm/hypervisor/xenserver/ovstunnel a4760b2
> server/src/com/cloud/api/ApiResponseHelper.java 090d9c2
> server/src/com/cloud/network/NetworkServiceImpl.java d4f9030
> server/src/com/cloud/network/element/VirtualRouterElement.java 1916678
> server/src/com/cloud/server/ManagementServerImpl.java 36b3879
> setup/db/create-schema.sql 143023a
> setup/db/db/schema-410to420.sql b48ae6a
> tools/apidoc/gen_toc.py 33a7e75
> ui/scripts/zoneWizard.js e2ad910
>
> Diff: https://reviews.apache.org/r/12941/diff/
>
>
> Testing
> -------
>
> Test done with following cases:
>
> + choose GRE method, VLAN range when deploy advanced zone
> + create new Network Offering and choose Ovs for VirtualNetworking service, VirtualRouter for other services.
> + create a new Guest network using this new NetworkOffering
> + deploy VMs on this Guest network
> + stop, restart, destroy VMs
> + deploy, stop, restart, destroy VMs on two hosts.
>
>
> Thanks,
>
> tuna
>
>
Re: Review Request 12941: [GSoC] refactor gre controller
Posted by tuna <ng...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12941/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 1:41 a.m.)
Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
Changes
-------
I made an update to refactor gre controller:
+ fix errors on preview patch
+ add OvsProvider to configPhysicalNetwork phase when deploying zone
+ remove sdn.ovs.controller to Global Setting
+ fix getLabel() //also work for multiNic servers
Repository: cloudstack-git
Description
-------
I made an update to refactor gre controller:
+ remove ovs_devices table, because we'll have an ODL plugin separately.
+ move command/answer to new package: com.cloud.agent.api
+ add Connectivity service checking
+ add new NetworkProvider: Ovs
+ add L3 services to Ovs Capabilities
+ add L3 services prototype code.
Next step:
+ L3 services implement with VirtualRouter
+ ODL plugin
Diffs (updated)
-----
api/src/com/cloud/network/Network.java a06208b
api/src/com/cloud/network/OvsProvider.java PRE-CREATION
api/src/com/cloud/network/element/VirtualRouterElementService.java ea971b8
api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb
api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java PRE-CREATION
client/tomcatconf/applicationContext.xml.in 60f1e30
client/tomcatconf/commands.properties.in 6ec4d92
engine/schema/src/com/cloud/network/dao/OvsProviderDao.java PRE-CREATION
engine/schema/src/com/cloud/network/dao/OvsProviderDaoImpl.java PRE-CREATION
engine/schema/src/com/cloud/network/element/OvsProviderVO.java PRE-CREATION
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b
plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110
plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac
scripts/vm/hypervisor/xenserver/ovstunnel a4760b2
server/src/com/cloud/api/ApiResponseHelper.java 090d9c2
server/src/com/cloud/network/NetworkServiceImpl.java d4f9030
server/src/com/cloud/network/element/VirtualRouterElement.java 1916678
server/src/com/cloud/server/ManagementServerImpl.java 36b3879
setup/db/create-schema.sql 143023a
setup/db/db/schema-410to420.sql b48ae6a
tools/apidoc/gen_toc.py 33a7e75
ui/scripts/zoneWizard.js e2ad910
Diff: https://reviews.apache.org/r/12941/diff/
Testing (updated)
-------
Test done with following cases:
+ choose GRE method, VLAN range when deploy advanced zone
+ create new Network Offering and choose Ovs for VirtualNetworking service, VirtualRouter for other services.
+ create a new Guest network using this new NetworkOffering
+ deploy VMs on this Guest network
+ stop, restart, destroy VMs
+ deploy, stop, restart, destroy VMs on two hosts.
Thanks,
tuna