[GitHub] [flink] vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators

[GitBox <gi...@apache.org>]

vthinkxie commented on a change in pull request #10988: Add commas to large numeric accumulators
URL: https://github.com/apache/flink/pull/10988#discussion_r384509858
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/accumulators/job-overview-drawer-accumulators.component.html
 ##########
 @@ -37,7 +37,10 @@
         <tr *ngFor="let accumulator of listOfAccumulator; trackBy:trackAccumulatorBy;">
           <td>{{ accumulator.name }}</td>
           <td>{{ accumulator.type }}</td>
-          <td>{{ accumulator.value }}</td>
+          <td *ngIf="isFinite(accumulator.value); else nonNumeric">{{ accumulator.value | number:'1.0-0' }}</td>
 
 Review comment:
   I'm not sure, but is the `{{accumulator.value}}` is always integer? if not we should not make it round to intergerwith `number:'1.0-0'`,`number:'1.0-3'` is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services