[GitHub] [arrow] pitrou commented on pull request #8145: ARROW-9967: [Python] Add compute module documentation

[GitBox <gi...@apache.org>]

pitrou commented on pull request #8145:
URL: https://github.com/apache/arrow/pull/8145#issuecomment-696105647


   Cython generally doesn't convert implicitly between arbitrary Python objects and C/C++ types, you have to type your code explicitly. Also, it is [better](https://cython.readthedocs.io/en/latest/src/userguide/special_methods.html#initialisation-methods-cinit-and-init) to use `__cinit__` here so that the constructor never gets skipped, so for example (untested):
   ```cython
       def __cinit__(self, int64_t pivot):
           self.partition_nth_options.reset(new CPartitionNthOptions(pivot))
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org