[jira] [Commented] (NIFI-3142) ExtractHL7Attributes processor does not route to REL_FAILURE for an exception other than an HL7Exception

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715516#comment-15715516 ] 

ASF GitHub Bot commented on NIFI-3142:
--------------------------------------

GitHub user klinvill opened a pull request:

    https://github.com/apache/nifi/pull/1290

    Fix NIFI-3142: ExtractHL7Attribute processor: Route a flowfile to REL_FAILURE if processing the flow…

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [n/a] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [n/a] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [n/a] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [n/a] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    … file throws an exception that is not an HL7Exception for the ExtractHL7Attribute processor.
    
    Fixed by changing the catch block to catch a throwable object instead of an HL7Exception object in the onTrigger method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klinvill/nifi NIFI-3142

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1290
    
----
commit 2f4a12e083be6acb8e5d2958c572e3428dc87458
Author: Kirby Linvill <ki...@teradata.com>
Date:   2016-12-02T14:08:03Z

    Fix NIFI-3142: Route a flowfile to REL_FAILURE if processing the flow file throws an exception that is not an HL7Exception for the ExtractHL7Attribute processor.
    
    Fixed by changing the catch block to catch a throwable object instead of an HL7Exception object in the onTrigger method.

----


> ExtractHL7Attributes processor does not route to REL_FAILURE for an exception other than an HL7Exception
> --------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3142
>                 URL: https://issues.apache.org/jira/browse/NIFI-3142
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.0.0
>            Reporter: Kirby Linvill
>            Priority: Minor
>              Labels: easyfix
>
> The ExtractHL7Attribute processor will not route a flowfile to REL_FAILURE if processing the flow file throws an exception that is not an HL7Exception. This bug is a result of the try catch block in the onTrigger method. It is easily fixed by changing the catch block to catch a throwable object. Change
> {noformat} 
> try {
>     ...
> } catch (final HL7Exception e) {
>     getLogger().error("Failed to extract attributes from {} due to {}", new Object[]{flowFile, e}, e);
>     session.transfer(flowFile, REL_FAILURE);
>     return;
> }
> {noformat} 
> to 
> {noformat} 
> try {
>     ...
> } catch (final Throwable t) {
>     getLogger().error("Failed to extract attributes from {} due to {}", new Object[]{flowFile, t}, t);
>     session.transfer(flowFile, REL_FAILURE);
>     return;
> }
> {noformat} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)