You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "Adalennis (via GitHub)" <gi...@apache.org> on 2026/10/13 11:57:40 UTC
[PR] Fix missing transform icons in the docs: CrateDB Bulk Loader, XML output (Advanced), Mask fields. #8893 (hop)
Adalennis opened a new pull request, #8894:
URL: https://github.com/apache/hop/pull/8894
Fixes #8893
The header icon of three transform pages in the user manual did not render:
- `cratedb-bulkloader.adoc` referenced `cratedbulkloader.svg`; the icon is `cratedbbulkloader.svg` (typo).
- `xmloutputadvanced.adoc` referenced `AXO.svg`, which was missing from the docs assets. Copied it from `plugins/transforms/xml/src/main/resources/AXO.svg` as `xmloutputadvanced.svg` and updated the reference.
- `maskfields.adoc` referenced `maskfields.svg`, which was missing from the docs assets. Copied it from `plugins/transforms/maskfields/src/main/resources/maskfields.svg`.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [ x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix missing transform icons in the docs: CrateDB Bulk Loader, XML output (Advanced), Mask fields. #8893 (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #8894:
URL: https://github.com/apache/hop/pull/8894#issuecomment-6148106934
LGTM.
I checked the icon references in the user manual pages against `main`. These three are the only broken ones, and after this PR all of them resolve. Both copied SVGs are byte-identical to the plugin resources they come from (`AXO.svg` and `maskfields.svg`), and both keep their license headers. I reviewed the files but didn't run the Antora build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix missing transform icons in the docs: CrateDB Bulk Loader, XML output (Advanced), Mask fields. #8893 (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #8894:
URL: https://github.com/apache/hop/pull/8894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org