You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Franz Fehringer (JIRA)" <ax...@ws.apache.org> on 2006/01/24 15:45:09 UTC
[jira] Created: (AXISCPP-918) generated copy constructor
wrong/incomplete
generated copy constructor wrong/incomplete
-------------------------------------------
Key: AXISCPP-918
URL: http://issues.apache.org/jira/browse/AXISCPP-918
Project: Axis-C++
Type: Bug
Components: Client - Stub
Versions: 1.6 Alpha
Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
Reporter: Franz Fehringer
Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
Only one of two class members gets copied (age), the other is omitted (t_Children_value).
Additional comments:
Initialization instead of assignment should be used in constructors.
For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (AXISCPP-918) generated copy constructor
wrong/incomplete
Posted by "Franz Fehringer (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-918?page=all ]
Franz Fehringer updated AXISCPP-918:
------------------------------------
Attachment: vakanz.wsdl
vakanz.xsd
> generated copy constructor wrong/incomplete
> -------------------------------------------
>
> Key: AXISCPP-918
> URL: http://issues.apache.org/jira/browse/AXISCPP-918
> Project: Axis-C++
> Type: Bug
> Components: Client - Stub
> Versions: 1.6 Alpha
> Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
> Reporter: Franz Fehringer
> Attachments: vakanz.wsdl, vakanz.xsd
>
> Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
> Only one of two class members gets copied (age), the other is omitted (t_Children_value).
> Additional comments:
> Initialization instead of assignment should be used in constructors.
> For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
> Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (AXISCPP-918) generated copy constructor wrong/incomplete
Posted by Franz Fehringer <fe...@isogmbh.de>.
yes for some time already.
franz
nadir amra (JIRA) schrieb:
> [ http://issues.apache.org/jira/browse/AXISCPP-918?page=comments#action_12460839 ]
>
> nadir amra commented on AXISCPP-918:
> ------------------------------------
>
> I believe it has been included in SVN....
>
>
>> generated copy constructor wrong/incomplete
>> -------------------------------------------
>>
>> Key: AXISCPP-918
>> URL: http://issues.apache.org/jira/browse/AXISCPP-918
>> Project: Axis-C++
>> Issue Type: Bug
>> Components: Client - Stub
>> Affects Versions: 1.6 Alpha
>> Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
>> Reporter: Franz Fehringer
>> Attachments: t_Children.cpp, vakanz.wsdl, vakanz.xsd
>>
>>
>> Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
>> Only one of two class members gets copied (age), the other is omitted (t_Children_value).
>> Additional comments:
>> Initialization instead of assignment should be used in constructors.
>> For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
>> Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
>>
>
>
[jira] Commented: (AXISCPP-918) generated copy constructor
wrong/incomplete
Posted by "nadir amra (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-918?page=comments#action_12460839 ]
nadir amra commented on AXISCPP-918:
------------------------------------
I believe it has been included in SVN....
> generated copy constructor wrong/incomplete
> -------------------------------------------
>
> Key: AXISCPP-918
> URL: http://issues.apache.org/jira/browse/AXISCPP-918
> Project: Axis-C++
> Issue Type: Bug
> Components: Client - Stub
> Affects Versions: 1.6 Alpha
> Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
> Reporter: Franz Fehringer
> Attachments: t_Children.cpp, vakanz.wsdl, vakanz.xsd
>
>
> Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
> Only one of two class members gets copied (age), the other is omitted (t_Children_value).
> Additional comments:
> Initialization instead of assignment should be used in constructors.
> For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
> Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXISCPP-918) generated copy constructor
wrong/incomplete
Posted by "Franz Fehringer (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-918?page=comments#action_12371719 ]
Franz Fehringer commented on AXISCPP-918:
-----------------------------------------
I achieved significant improvement for me with
$ svn diff c/src/wsdl/org/apache/axis/wsdl/wsdl2ws/cpp/literal/BeanParamWriter.java
Index: c/src/wsdl/org/apache/axis/wsdl/wsdl2ws/cpp/literal/BeanParamWriter.java
===================================================================
--- c/src/wsdl/org/apache/axis/wsdl/wsdl2ws/cpp/literal/BeanParamWriter.java (revision 388095)
+++ c/src/wsdl/org/apache/axis/wsdl/wsdl2ws/cpp/literal/BeanParamWriter.java (working copy)
@@ -1142,6 +1142,13 @@
//write copy constructor
writer.write("\n" + classname + "::" + classname + "(const " + classname + " & original)\n{\n");
+
+ if (extensionBaseAttrib != null && extensionBaseAttrib.getTypeName() != null)
+ {
+ writer.write("\t" + extensionBaseAttrib.getParamNameAsMember() + " = " + "original." + extensionBaseAttrib.getParamNameAsMember() + ";\n");
+
+ }
+
int anyCounter = 0;
for (int i = 0 ; i < attribs.length ; i++)
{
@@ -1516,4 +1523,5 @@
return moreThanOne;
}
-}
\ No newline at end of file
+}
+
While this is by no means a complete solution, perhaps it could be whipped up and included in SVN?
> generated copy constructor wrong/incomplete
> -------------------------------------------
>
> Key: AXISCPP-918
> URL: http://issues.apache.org/jira/browse/AXISCPP-918
> Project: Axis-C++
> Type: Bug
> Components: Client - Stub
> Versions: 1.6 Alpha
> Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
> Reporter: Franz Fehringer
> Attachments: t_Children.cpp, vakanz.wsdl, vakanz.xsd
>
> Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
> Only one of two class members gets copied (age), the other is omitted (t_Children_value).
> Additional comments:
> Initialization instead of assignment should be used in constructors.
> For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
> Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXISCPP-918) generated copy constructor
wrong/incomplete
Posted by "Adrian Dick (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-918?page=comments#action_12368386 ]
Adrian Dick commented on AXISCPP-918:
-------------------------------------
I think the problem you describe is due to WSDL2Ws having very limited support for xsd:extension.
This is an area we need to test and improve.
> generated copy constructor wrong/incomplete
> -------------------------------------------
>
> Key: AXISCPP-918
> URL: http://issues.apache.org/jira/browse/AXISCPP-918
> Project: Axis-C++
> Type: Bug
> Components: Client - Stub
> Versions: 1.6 Alpha
> Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
> Reporter: Franz Fehringer
> Attachments: t_Children.cpp, vakanz.wsdl, vakanz.xsd
>
> Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
> Only one of two class members gets copied (age), the other is omitted (t_Children_value).
> Additional comments:
> Initialization instead of assignment should be used in constructors.
> For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
> Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (AXISCPP-918) generated copy constructor
wrong/incomplete
Posted by "Franz Fehringer (JIRA)" <ax...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/AXISCPP-918?page=all ]
Franz Fehringer updated AXISCPP-918:
------------------------------------
Attachment: t_Children.cpp
> generated copy constructor wrong/incomplete
> -------------------------------------------
>
> Key: AXISCPP-918
> URL: http://issues.apache.org/jira/browse/AXISCPP-918
> Project: Axis-C++
> Type: Bug
> Components: Client - Stub
> Versions: 1.6 Alpha
> Environment: WIN2KSP4 JDK1.5.0_06 MSVC6SP6
> Reporter: Franz Fehringer
> Attachments: t_Children.cpp, vakanz.wsdl, vakanz.xsd
>
> Wsdl2ws generates for the t_Children class from my attached example an incomplete copy constructor.
> Only one of two class members gets copied (age), the other is omitted (t_Children_value).
> Additional comments:
> Initialization instead of assignment should be used in constructors.
> For this simple example no copy constructor should be generated at all, since the compiler does it right without a line of code.
> Last, if a userdefined copy constructor is to be provided, a user defined assignment operator should be provided too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira