[GitHub] [helix] dasahcc removed a comment on pull request #1237: Add error message of instance check to stoppable API response

[GitBox <gi...@apache.org>]

dasahcc removed a comment on pull request #1237:
URL: https://github.com/apache/helix/pull/1237#issuecomment-671586099


   > > Error message for server side is clear to find out the fail reason. The more important is let user to understand what is the real fail reason. Do we have that if persist assignment turned off, at least, we gave user info EV and IS does not match.
   > 
   > @dasahcc This PR is to provide the info to let users know the reason. The root cause is exception/error is not returned as response. This PR adds the exception/error message to not stoppable reason in the return response.
   > https://github.com/apache/helix/pull/1237/files#diff-c98c0908866d29b64f625e799c198d15R224-R227
   > 
   > The result will be what is the description
   > 
   > ```
   > curl -XPOST http://localhost:8100/admin/v2/namespaces/namespacce/clusters/cluster/instances\?command\=stoppable -d ' {"instances": ["instance"], "selection_base": "zone_based", "max_instance": "2", "customized_values": "{}"}' -H "Content-Type: application/json"
   > {
   >   "instance_stoppable_parallel" : [ ],
   >   "instance_not_stoppable_with_reasons" : {
   >     "instance" : [ "HELIX:Instance stability check needs persist assignment cluster config turned on: PERSIST_INTERMEDIATE_ASSIGNMENT = true" ]
   >   }
   > }
   > ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org