You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/27 03:33:22 UTC

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster 

Hello Dan Burkert, Anonymous Coward #314, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9814

to review the following change.


Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................

KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

In the case that exportAuthenticationCredentials is called before the
client has connected to the cluster, it needs to trigger a connection in
order to obtain credentials. KUDU-2259 broke this when it changed
exportAuthenticationCredentials() to return a non-null credential in
this case.

The fix just tracks whether the client has successfully connected to a
cluster, and if it has not, makes sure that it has done so before
generating credentials.

Tested manually using spark2-submit against a secure cluster. Prior to
this fix, it did not succeed. A new unit test is included as well.

Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
2 files changed, 28 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/9814/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Anonymous Coward #314
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1:
> 
> One thought I had about this: do we need to also do something to ensure that, if the Spark driver has connected to the cluster, but the token is expired, that it proactively re-connects to get a new token to propagate to the executors?

Prior to KUDU-2259 landing it doesn't appear that we explicitly handled this, unless I'm missing something.

In addition, I believe exportAuthenticationCredentials is only called once in the life of a Kudu/Spark job, when the KuduContext is being constructed (it's cached as a serializable val).

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@175
PS1, Line 175:     startCluster(ImmutableSet.of(Option.SHORT_TOKENS_AND_TICKETS,
Are these options necessary?



-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:28:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9814

to look at the new patch set (#3).

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................

KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

In the case that exportAuthenticationCredentials is called before the
client has connected to the cluster, it needs to trigger a connection in
order to obtain credentials. KUDU-2259 broke this when it changed
exportAuthenticationCredentials() to return a non-null credential in
this case.

The fix just tracks whether the client has successfully connected to a
cluster, and if it has not, makes sure that it has done so before
generating credentials.

Tested manually using spark2-submit against a secure cluster. Prior to
this fix, it did not succeed. A new unit test is included as well.

Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 38 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/9814/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

> Or are we assuming that once every 7 days, the driver will crash and restart itself and pick up a new token?

Hmm well I'm not assuming that, since I doubt Spark handles that by restarting the driver (I think it would kill the job).  Perhaps Spark streaming or something similar could handle it, though.
 
> Meanwhile since I think we agree that the above isn't a regression since 1.6 we can move ahead with this patch, right?

Right, I tend to agree.


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:42:45 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................

KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

In the case that exportAuthenticationCredentials is called before the
client has connected to the cluster, it needs to trigger a connection in
order to obtain credentials. KUDU-2259 broke this when it changed
exportAuthenticationCredentials() to return a non-null credential in
this case.

The fix just tracks whether the client has successfully connected to a
cluster, and if it has not, makes sure that it has done so before
generating credentials.

Tested manually using spark2-submit against a secure cluster. Prior to
this fix, it did not succeed. A new unit test is included as well.

Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Reviewed-on: http://gerrit.cloudera.org:8080/9814
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 38 insertions(+), 4 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

One thought I had about this: do we need to also do something to ensure that, if the Spark driver has connected to the cluster, but the token is expired, that it proactively re-connects to get a new token to propagate to the executors?


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 16:24:03 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed Anonymous Coward #314 from this change.  ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Removed reviewer null.
-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 23:13:37 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 2: Code-Review+1

lgtm, but I think we should check if AuthnToken is empty before assign it at https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java#L313. Otherwise a default value is used. Sorry that I should catch this in the previous review cycle.


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:08:53 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> (1 comment)
> 
> > Patch Set 1:
> > 
> > One thought I had about this: do we need to also do something to ensure that, if the Spark driver has connected to the cluster, but the token is expired, that it proactively re-connects to get a new token to propagate to the executors?
> 
> Prior to KUDU-2259 landing it doesn't appear that we explicitly handled this, unless I'm missing something.
> 
> In addition, I believe exportAuthenticationCredentials is only called once in the life of a Kudu/Spark job, when the KuduContext is being constructed (it's cached as a serializable val).

Yea, I don't think the "reacquire" is necessarily a regression, just something I was thinking about in the context of this fix.

As for whether export is called multiple times, I think you're right. I think at one point we were discussing hooking serialization so that each time a new task was started and the KuduContext was serialized to that task it would ensure it got a new token. Does this mean we don't support spark jobs which run longer than the token expiry interval? Or are we assuming that once every 7 days, the driver will crash and restart itself and pick up a new token?

Meanwhile since I think we agree that the above isn't a regression since 1.6 we can move ahead with this patch, right?


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:31:53 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

> > Or are we assuming that once every 7 days, the driver will crash
 > and restart itself and pick up a new token?
 > 
 > Hmm well I'm not assuming that, since I doubt Spark handles that by
 > restarting the driver (I think it would kill the job).  Perhaps
 > Spark streaming or something similar could handle it, though.
 > 
 > > Meanwhile since I think we agree that the above isn't a
 > regression since 1.6 we can move ahead with this patch, right?
 > 
 > Right, I tend to agree.

+1 on the latter.


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 18:45:01 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9814

to look at the new patch set (#2).

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................

KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

In the case that exportAuthenticationCredentials is called before the
client has connected to the cluster, it needs to trigger a connection in
order to obtain credentials. KUDU-2259 broke this when it changed
exportAuthenticationCredentials() to return a non-null credential in
this case.

The fix just tracks whether the client has successfully connected to a
cluster, and if it has not, makes sure that it has done so before
generating credentials.

Tested manually using spark2-submit against a secure cluster. Prior to
this fix, it did not succeed. A new unit test is included as well.

Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
2 files changed, 30 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/9814/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review+1
> 
> lgtm, but I think we should check if AuthnToken is empty before assign it at https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java#L313. Otherwise a default value is used. Sorry that I should catch this in the previous review cycle.

good catch, this should improve the error messages. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:54:16 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:23:08 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@310
PS1, Line 310:    * Set to true once we have connected to a master at least once.
> Can we specify here this is for indicating whether to export authn?
Done


http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@175
PS1, Line 175:     startCluster(ImmutableSet.of(Option.SHORT_TOKENS_AND_TICKETS,
> Are these options necessary?
Yea the test fails without the fix. The options arent necessary, removed them.



-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 20:52:49 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:58:32 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9814 )

Change subject: KUDU-2379. java: exportAuthenticationCredentials must connect to the cluster
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@310
PS1, Line 310:    * Set to true once we have connected to a master at least once.
Can we specify here this is for indicating whether to export authn?


http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:

http://gerrit.cloudera.org:8080/#/c/9814/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@175
PS1, Line 175:     startCluster(ImmutableSet.of(Option.SHORT_TOKENS_AND_TICKETS,
Will this test certainly fail without the fix?



-- 
To view, visit http://gerrit.cloudera.org:8080/9814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1b69abadb4b9c97f6c8f7ed38897c33ca7ff72
Gerrit-Change-Number: 9814
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 27 Mar 2018 05:04:27 +0000
Gerrit-HasComments: Yes