You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Nicolas Malin (JIRA)" <ji...@apache.org> on 2012/08/29 18:08:07 UTC
[jira] [Created] (OFBIZ-5020) change serviceName by customMethod on
Content
Nicolas Malin created OFBIZ-5020:
------------------------------------
Summary: change serviceName by customMethod on Content
Key: OFBIZ-5020
URL: https://issues.apache.org/jira/browse/OFBIZ-5020
Project: OFBiz
Issue Type: Improvement
Components: content
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Priority: Minor
At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446661#comment-13446661 ]
Adrian Crum commented on OFBIZ-5020:
------------------------------------
What you call a "column name trick" is what I call an ugly hack that will lead to hours spent trying to debug quirky behavior. The "trick" will not work on databases that use upper case column names.
There are many instances where OFBiz provides more than one path to a solution. I don't agree that this pattern causes confusion.
This could be a simple enhancement, but both of you are trying to make it unnecessarily complicated. Add the new field and a bit of code to use it and you're done.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5020) change serviceName by customMethod on
Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin updated OFBIZ-5020:
---------------------------------
Attachment: OFBIZ-5020.patch
I added a service migration that search or create CustomMethod corresponding to serviceName associate to entityName's value
The service take a entityName (as Content) allowing its use for other Entity
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446660#comment-13446660 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
Adrian,
Yesterday I talked with Nicolas. It's because he wants to encourage people to use the new method.
IMO, the alternatives are:
# using both, by keeping serviceName as is and adding the new field. This was 1st suggested by BJ and you seem to be inclined to this too
** advantages: minimal changes, not need to provide a way for user to migrate their data
** drawbacks: it's not clear what to use. There is a redundant way of doing the same thing. Which demo data should be kept/added OOTB?
# rename the serviceName field to oldServiceName but not use the col-name trick
** advantages: follow the standard procedure, clear path, no redundancy
** drawbacks:
*** the contributor or committer needs to provide a way for user to migrate their data for existent DBs
*** the user with an existent DB must detect the change, find the procedure to migrate data in the wiki, and apply the change to DB.
# rename the serviceName field to oldServiceName and use the col-name trick
** advantages: ,
*** the contributor or committer don't need to provide a way for user to migrate their data
*** the user does not need to do anything: it's done silently/automatically when updating code and possibly reloading
** drawbacks:
*** on an existing DB, if the user reload data the DB ends with duplicated data (demo only IIIRW). The user is not aware of that unless if looks closely at this commit, Jira, or in the Content Entity
*** minor: in a new DB the The Content.oldServiceName field will be named service_name in the DB. so SQL queries using old_Service_Name will not work.
Not sure I put all advantages and drawbacks. At least that's what I have in my mind.
Actually Nicolas called me after I put my Jira comment for the commit above. Like you Adrian, I did not spot the col-name trick. So in my Jira comment above I asked Nicolas to follow the std (2nd) procedure. Hence to provide a way for users to migrate their data. But then he explained me he used the col-name trick. I thought it was clever and supported it. I thought more about it this morning and the 3 points above follows. Note that I'm not clearly decided. But if it was only me I'd use the 3rd way: it's safe, clarify (give an information to users to follow the new way), and avoid the migration burden.
The reason I put much efforts in this is because I would like the community to think about the last (3rd) solution, instead of always using the 2nd (in some cases clearly using the 2nd would be better, here the change in code is easy). The 1st seems unclear to me (confusing, redundant) but is the one with less work.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-5020) change serviceName by customMethod on
Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-5020.
----------------------------------
Resolution: Fixed
Thanks Nicolas, Adrian, Scott,
Finally done at revision: 1379937 in trunk, keeping serviceName field for backward compatibility, no migration needed
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446729#comment-13446729 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
BTW, happy to get rid of this, we have bigger fishes to fry...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446641#comment-13446641 ]
Nicolas Malin commented on OFBIZ-5020:
--------------------------------------
Ok Jacques,
I wait the revert and create a complete patch.
specialpurpose/birt/webapp/birt/report/example.rptdesign is an error. I will update the patch asap your revert
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5020) change serviceName by customMethod on
Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin updated OFBIZ-5020:
---------------------------------
Attachment: OFBIZ-5020.patch
run run-tests without error
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Priority: Minor
> Attachments: OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447175#comment-13447175 ]
Nicolas Malin commented on OFBIZ-5020:
--------------------------------------
Thanks Jacques for your involvement !
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446639#comment-13446639 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
Hi Nicolas,
To keep things clear, I will revert my commit at r13783989 and will ask you to provide a new complete replacement patch.
BTW, I guess specialpurpose/birt/webapp/birt/report/example.rptdesign has slipped in without notice in your last patch?
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446817#comment-13446817 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
This is where it shows that there is nothing worse than a non updated documentation...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5020) change serviceName by
customMethod on Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446012#comment-13446012 ]
Nicolas Malin edited comment on OFBIZ-5020 at 9/1/12 1:49 AM:
--------------------------------------------------------------
Correct demo data present on specialpurpose folder and add CustomMethodType and CustomMetch missed on AccountingTypeData.xml
after ant clean-all load-demo run-tests
with result :
Tests Failures Errors Success rate Time
804 0 0 100.00% 1093.592
Thanks Jacques and Scott for your observation
was (Author: soledad):
Correct demo data present on specialpurpose folder and add CustomMethodType and CustomMetch missed on AccountingTypeData.xml
after ant clean-all load-demo run-tests
with result :
Failures Errors Success rate Time
804 0 0 100.00% 1093.592
Thanks Jacques and Scott for your observation
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5020) change serviceName by
customMethod on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446660#comment-13446660 ]
Jacques Le Roux edited comment on OFBIZ-5020 at 9/1/12 11:08 PM:
-----------------------------------------------------------------
== TYPO: userS ==
Adrian,
Yesterday I talked with Nicolas. It's because he wants to encourage people to use the new method.
IMO, the alternatives are:
# using both, by keeping serviceName as is and adding the new field. This was 1st suggested by BJ and you seem to be inclined to this too
** advantages: minimal changes, not need to provide a way for users to migrate their data
** drawbacks: it's not clear what to use. There is a redundant way of doing the same thing. Which demo data should be kept/added OOTB?
# rename the serviceName field to oldServiceName but not use the col-name trick
** advantages: follow the standard procedure, clear path, no redundancy
** drawbacks:
*** the contributor or committer needs to provide a way for users to migrate their data for existent DBs
*** the user with an existent DB must detect the change, find the procedure to migrate data in the wiki, and apply the change to DB.
# rename the serviceName field to oldServiceName and use the col-name trick
** advantages: ,
*** the contributor or committer don't need to provide a way for users to migrate their data
*** the user does not need to do anything: it's done silently/automatically when updating code and possibly reloading
** drawbacks:
*** on an existing DB, if the user reload data the DB ends with duplicated data (demo only IIIRW). The user is not aware of that unless if looks closely at this commit, Jira, or in the Content Entity
*** minor: in a new DB the The Content.oldServiceName field will be named service_name in the DB. so SQL queries using old_Service_Name will not work.
Not sure I put all advantages and drawbacks. At least that's what I have in my mind.
Actually Nicolas called me after I put my Jira comment for the commit above. Like you Adrian, I did not spot the col-name trick. So in my Jira comment above I asked Nicolas to follow the std (2nd) procedure. Hence to provide a way for users to migrate their data. But then he explained me he used the col-name trick. I thought it was clever and supported it. I thought more about it this morning and the 3 points above follows. Note that I'm not clearly decided. But if it was only me I'd use the 3rd way: it's safe, clarify (give an information to users to follow the new way), and avoid the migration burden.
The reason I put much efforts in this is because I would like the community to think about the last (3rd) solution, instead of always using the 2nd (in some cases clearly using the 2nd would be better, here the change in code is easy). The 1st seems unclear to me (confusing, redundant) but is the one with less work.
was (Author: jacques.le.roux):
Adrian,
Yesterday I talked with Nicolas. It's because he wants to encourage people to use the new method.
IMO, the alternatives are:
# using both, by keeping serviceName as is and adding the new field. This was 1st suggested by BJ and you seem to be inclined to this too
** advantages: minimal changes, not need to provide a way for user to migrate their data
** drawbacks: it's not clear what to use. There is a redundant way of doing the same thing. Which demo data should be kept/added OOTB?
# rename the serviceName field to oldServiceName but not use the col-name trick
** advantages: follow the standard procedure, clear path, no redundancy
** drawbacks:
*** the contributor or committer needs to provide a way for user to migrate their data for existent DBs
*** the user with an existent DB must detect the change, find the procedure to migrate data in the wiki, and apply the change to DB.
# rename the serviceName field to oldServiceName and use the col-name trick
** advantages: ,
*** the contributor or committer don't need to provide a way for user to migrate their data
*** the user does not need to do anything: it's done silently/automatically when updating code and possibly reloading
** drawbacks:
*** on an existing DB, if the user reload data the DB ends with duplicated data (demo only IIIRW). The user is not aware of that unless if looks closely at this commit, Jira, or in the Content Entity
*** minor: in a new DB the The Content.oldServiceName field will be named service_name in the DB. so SQL queries using old_Service_Name will not work.
Not sure I put all advantages and drawbacks. At least that's what I have in my mind.
Actually Nicolas called me after I put my Jira comment for the commit above. Like you Adrian, I did not spot the col-name trick. So in my Jira comment above I asked Nicolas to follow the std (2nd) procedure. Hence to provide a way for users to migrate their data. But then he explained me he used the col-name trick. I thought it was clever and supported it. I thought more about it this morning and the 3 points above follows. Note that I'm not clearly decided. But if it was only me I'd use the 3rd way: it's safe, clarify (give an information to users to follow the new way), and avoid the migration burden.
The reason I put much efforts in this is because I would like the community to think about the last (3rd) solution, instead of always using the 2nd (in some cases clearly using the 2nd would be better, here the change in code is easy). The 1st seems unclear to me (confusing, redundant) but is the one with less work.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5020) change serviceName by customMethod on
Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin updated OFBIZ-5020:
---------------------------------
Attachment: OFBiz-5020-migrate.patch
OFBiz-5020.patch
Hi,
I update the patch with the first solution without upgrade service.
I create a new patch that contains only upgrade service OFBiz-5020-migrate.patch
just to don't waste time for all, on wiki page I found this :
{quote}
Deprecated Entities
...
When changing the name of a field, or deprecating and replacing a field that does not require deprecation of the entire entity, then follow the same pattern leaving the old field there: a "old" prefix added to the field name, change the original first letter to upper case, and specify the column-name for the field so it is the same as the original field name. For example if you are changing the "uomId" field to a new name then change the field name to "oldUomId" and specify a column-name of "UOM_ID". Just as when replacing and entity, make sure to write a service to move the data from the old field to the new one.
{quote}
It's a best pratice or not ? Because I followed this to make my improvement, and I'm a little disturbed by the response around my initial proposition (It's just to understand and improve my issue quality)
Thks
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446814#comment-13446814 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
Hi Nicolas,
Yes, then it's come back to my initial request in my Jira comment of the commit which I wrote from the top of my head w/out checking anything (like you to be able to edit this page)
{quote}
Since you replaced the serviceName by oldServiceName please fill an entry in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29
{quote}
The only differences with the patch you proved intially are
* you did not write the col-name in upper case (not sure why it should be upper case rather than lower though) but rather suggested this (quoting you in dev ML) <<On my initial proposition, I keep serviceName on oldServiceName for transparent evolution without script migration. An other solution will
be convert all serviceName present on Content to customMethod data by conversion script>>
* you take into account the oldServiceName field in your code for backward compatibility, which was for me rather a good thing for people which might have been missed the migration script in wiki. But then it was confusing ;)
It's too late for me tonight, but yes we have to check that...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5020) change serviceName by
customMethod on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446727#comment-13446727 ]
Jacques Le Roux edited comment on OFBIZ-5020 at 9/2/12 2:02 AM:
----------------------------------------------------------------
== ADD "less error prone" ==
BTW Nicolas, if ever you go the 2nd way, have a look at applications/accounting/servicedef/services_upgrade.xml. This does not mean that I'm for this solution. The more I think about it the more I agree with BJ and Adrian: 1st is easier and less error prone... I'd just put a comment in field description as I said...
was (Author: jacques.le.roux):
BTW Nicolas, if ever you go the 2nd way, have a look at applications/accounting/servicedef/services_upgrade.xml. This does not mean that I'm for this solution. The more I think about it the more I agree with BJ and Adrian: 1st is easier... I'd just put a comment in field description as I said...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446725#comment-13446725 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
OK, the databases which use upper case column names is a strong argument against 3rd solution I did not think about. I'd then personnally be more inclined with the std solution (2nd). Then it's clear and without possible confusion, notably about seed and demo data.
I guess one of the reasons which pushed Nicolas to this change is that AccountingTypeData.xml are seed data with for instance
<CustomMethodType customMethodTypeId="FIN_CAPTURE" parentTypeId="" hasTable="N" description="FIN account capture methods"/>
<CustomMethodType customMethodTypeId="FIN_REFUND" parentTypeId="" hasTable="N" description="FIN account refund methods"/>
<CustomMethodType customMethodTypeId="FIN_RELEASE" parentTypeId="" hasTable="N" description="FIN account release methods"/>
but nothing for
+ <CustomMethodType customMethodTypeId="FIN_PURCHASE" parentTypeId="" hasTable="N" description="FIN account purchase methods"/>
See his last patches for more about that (followed Scott's remark). Now it's up to you Nicolas, the 1st solution is clearly easier, you could just add a comment about the new solution in the field description without changing the field name... Then no need to update the wiki page, etc.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446816#comment-13446816 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
Agreed Adrian, I tested it this afternoon on Postgres 9.1. If in a newly created DB you rename service_name by SERVICE_NAME then on next start OFBIz will re-create a service_name. By default Postgres is case sensitive (Google for "Postgres column case sensitive"). I saw MySql (and MSQL I think) can be tuned for that, anyway I don't use MySql (nor MSQL)
Note: this upper cased field names technique was used in the pre Apache era. It's easy to find trace in data model looking for col-name (thanks to Nicolas who mentionned it), but there are no corresponding commits in the Apache repo (at least I did not find one)
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446727#comment-13446727 ]
Jacques Le Roux commented on OFBIZ-5020:
----------------------------------------
BTW Nicolas, if ever you go the 2nd way, have a look at applications/accounting/servicedef/services_upgrade.xml. This does not mean that I'm for this solution. The more I think about it the more I agree with BJ and Adrian: 1st is easier... I'd just put a comment in field description as I said...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-5020) change serviceName by customMethod on
Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin updated OFBIZ-5020:
---------------------------------
Attachment: OFBIZ-5020.patch
Correct demo data present on specialpurpose folder and add CustomMethodType and CustomMetch missed on AccountingTypeData.xml
after ant clean-all load-demo run-tests
with result :
Failures Errors Success rate Time
804 0 0 100.00% 1093.592
Thanks Jacques and Scott for your observation
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Nicolas Malin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Malin reopened OFBIZ-5020:
----------------------------------
Scott raise an error on demo data. After check, the serviceName on content is also use on order component on service OrderServices.fulfillDigitalItems
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OFBIZ-5020) change serviceName by
customMethod on Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446814#comment-13446814 ]
Jacques Le Roux edited comment on OFBIZ-5020 at 9/2/12 8:38 AM:
----------------------------------------------------------------
== WRAP LINE ==
Hi Nicolas,
Yes, then it's come back to my initial request in my Jira comment of the commit which I wrote from the top of my head w/out checking anything (like you to be able to edit this page)
{quote}
Since you replaced the serviceName by oldServiceName please fill an entry in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29
{quote}
The only differences with the patch you proved intially are
* you did not write the col-name in upper case (not sure why it should be upper case rather than lower though) but rather suggested this (quoting you in dev ML) <<On my initial proposition, I keep serviceName on oldServiceName for transparent evolution without script migration. An other solution will be convert all serviceName present on Content to customMethod data by conversion script>>
* you take into account the oldServiceName field in your code for backward compatibility, which was for me rather a good thing for people which might have been missed the migration script in wiki. But then it was confusing ;)
was (Author: jacques.le.roux):
Hi Nicolas,
Yes, then it's come back to my initial request in my Jira comment of the commit which I wrote from the top of my head w/out checking anything (like you to be able to edit this page)
{quote}
Since you replaced the serviceName by oldServiceName please fill an entry in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29
{quote}
The only differences with the patch you proved intially are
* you did not write the col-name in upper case (not sure why it should be upper case rather than lower though) but rather suggested this (quoting you in dev ML) <<On my initial proposition, I keep serviceName on oldServiceName for transparent evolution without script migration. An other solution will
be convert all serviceName present on Content to customMethod data by conversion script>>
* you take into account the oldServiceName field in your code for backward compatibility, which was for me rather a good thing for people which might have been missed the migration script in wiki. But then it was confusing ;)
It's too late for me tonight, but yes we have to check that...
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446645#comment-13446645 ]
Adrian Crum commented on OFBIZ-5020:
------------------------------------
What is wrong with leaving the existing field as-is? I would prefer to use a service and avoid the extra work required by the new method.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-5020) change serviceName by customMethod
on Content
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446813#comment-13446813 ]
Adrian Crum commented on OFBIZ-5020:
------------------------------------
That paragraph from the wiki is terrible advice. As I mentioned already, it will not work on all databases.
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBiz-5020-migrate.patch, OFBiz-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch, OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-5020) change serviceName by customMethod on
Content
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-5020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-5020.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux
Thanks Nicolas,
Your patch is in trunk at r1379389.
Since you replaced the serviceName by oldServiceName please fill an entry in https://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration+%28upgrade+ofbiz%29
> change serviceName by customMethod on Content
> ---------------------------------------------
>
> Key: OFBIZ-5020
> URL: https://issues.apache.org/jira/browse/OFBIZ-5020
> Project: OFBiz
> Issue Type: Improvement
> Components: content
> Affects Versions: SVN trunk
> Reporter: Nicolas Malin
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5020.patch
>
>
> At this time, when you use a content as template, the content.serviceName value use to call the context populate service before rendering.
> I propose to replace serviceName field by customMethodId and use customMethod pattern for more flexibility.
> serviceName field will be move to oldServiceName field for backward compatibility
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira