[GitHub] [openwhisk-client-go] mdeuser commented on a change in pull request #133: Parse an action's application error

[GitBox <gi...@apache.org>]

mdeuser commented on a change in pull request #133: Parse an action's application error
URL: https://github.com/apache/openwhisk-client-go/pull/133#discussion_r357920362
 
 

 ##########
 File path: whisk/client.go
 ##########
 @@ -616,6 +618,55 @@ func parseApplicationError(resp *http.Response, data []byte, v interface{}) (*ht
 	return resp, whiskErr
 }
 
+func getApplicationErrorMessage(errResp interface{}) string {
 
 Review comment:
   @mrutkows this fix is primarily for usage by the trigger create/delete code.  this cli code invokes the action internally, and needs the error response details.  without this pr, the error details are missing.  here's the cli routine that invokes the client-go code. https://github.com/apache/openwhisk-cli/blob/368da5bf3d34b4a9b64204a0876618d79e014146/commands/trigger.go#L80
   
   without this pr, you can see that the err returned from the `Client.Triggers.Insert` does not have the failure details when you create a trigger using your own "bad" feed action.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services